Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not enforce file extensions #297

Closed
wants to merge 1 commit into from
Closed

Do not enforce file extensions #297

wants to merge 1 commit into from

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 9, 2022

Set the enforceExtension option

In future we may want to require extensions to stay up-to-date with the ecosystem e.g. Node.js 14 docs

Also see nextcloud-libraries/eslint-config#292

@Pytal
Do not enforce extensions
1ff7bdd 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added the enhancement New feature or request label Feb 9, 2022
@Pytal Pytal requested a review from a team February 9, 2022 19:34
@Pytal Pytal self-assigned this Feb 9, 2022
@Pytal Pytal requested review from PVince81, artonge and szaimen and removed request for a team February 9, 2022 19:34
@Pytal Pytal mentioned this pull request Feb 9, 2022
Merged
@Pytal
Copy link
Contributor Author

Pytal commented Feb 11, 2022

As discussed in nextcloud-libraries/eslint-config#292, there will just be an eslint warning and this can be enforced in a year or so

artonge
artonge requested changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we add the property to set it to its default value? Is this really necessary?

@Pytal
Copy link
Contributor Author

Pytal commented Feb 15, 2022

So we add the property to set it to its default value? Is this really necessary?

Perhaps not, will close in favour of the issue #303

@Pytal Pytal closed this Feb 15, 2022
@skjnldsv skjnldsv deleted the enh/disable-enforce-extension-explicitly branch February 21, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge requested changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @artonge