Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CI): Add PHPUnit testing for PHP 8.2 #125

Merged
merged 2 commits into from
Feb 17, 2023
Merged

feat(CI): Add PHPUnit testing for PHP 8.2 #125

merged 2 commits into from
Feb 17, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen
feat(CI): Add PHPUnit testing for PHP 8.2
285a9f5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 2, 2023
@nickvergessen nickvergessen self-assigned this Feb 2, 2023
@nickvergessen
Copy link
Member Author

Should we also add this?

nextcloud/server@f0e88ce#diff-dafcb7f3e7c61408e9b52befb8a557ba90eb708d6f55fcc265447776152678cdR39

@come-nc
Copy link
Contributor

come-nc commented Feb 2, 2023

See also nextcloud/server#32463

@come-nc
Copy link
Contributor

come-nc commented Feb 2, 2023

Should we also add this?

nextcloud/server@f0e88ce#diff-dafcb7f3e7c61408e9b52befb8a557ba90eb708d6f55fcc265447776152678cdR39

Yes please.

@nickvergessen
Use development ini file
33cbd63 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz
Copy link
Member

blizzz commented Feb 17, 2023

What's the thing with the ini file?

@blizzz blizzz mentioned this pull request Feb 17, 2023
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 17, 2023 •
edited
Loading

What's the thing with the ini file?

The ini file is from PHP upstream as far as I can tell
https://github.com/shivammathur/setup-php#ini-file-optional

@nickvergessen nickvergessen merged commit 1335b8f into master Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/add-unittesting-for-php-8.2 branch February 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @come-nc @blizzz