Remove status on REPORT

[tobiasKaminsky]

Solves: nextcloud/server#15029

It seems that status is not allowed on top level, but only in prop/allprop.

Before:

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
    <d:response>
        <d:status>HTTP/1.1 200 OK</d:status>
        <d:href>/nc/remote.php/dav/files/test/testFolder</d:href>
        <d:propstat>
            <d:prop>
                <oc:owner-id>test</oc:owner-id>
                <d:getetag>&quot;5cad995a5281a&quot;</d:getetag>
                <oc:permissions>RGDNVCK</oc:permissions>
                <d:getlastmodified>Wed, 10 Apr 2019 07:20:58 GMT</d:getlastmodified>
                <oc:id>00080126ocjycgrudn78</oc:id>
                <oc:favorite>1</oc:favorite>
                <nc:mount-type></nc:mount-type>
                <nc:note></nc:note>
                <nc:has-preview>false</nc:has-preview>
                <oc:size>0</oc:size>
                <nc:is-encrypted>0</nc:is-encrypted>
                <oc:owner-display-name>test</oc:owner-display-name>
                <oc:comments-unread>0</oc:comments-unread>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <d:creationdate/>
                <d:getcontentlength/>
                <d:getcontenttype/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>
</d:multistatus>

After:

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
    <d:response>
        <d:href>/nc/remote.php/dav/files/test/testFolder</d:href>
        <d:propstat>
            <d:prop>
                <oc:owner-id>test</oc:owner-id>
                <d:getetag>&quot;5cad995a5281a&quot;</d:getetag>
                <oc:permissions>RGDNVCK</oc:permissions>
                <d:getlastmodified>Wed, 10 Apr 2019 07:20:58 GMT</d:getlastmodified>
                <oc:id>00080126ocjycgrudn78</oc:id>
                <oc:favorite>1</oc:favorite>
                <nc:mount-type></nc:mount-type>
                <nc:note></nc:note>
                <nc:has-preview>false</nc:has-preview>
                <oc:size>0</oc:size>
                <nc:is-encrypted>0</nc:is-encrypted>
                <oc:owner-display-name>test</oc:owner-display-name>
                <oc:comments-unread>0</oc:comments-unread>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <d:creationdate/>
                <d:getcontentlength/>
                <d:getcontenttype/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>
</d:multistatus>

As you can see we still have <d:status>…</d:status>, but only with in propstat.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[MorrisJobke]

🙈 You are patching a library. Maybe this should be fixed upstream as well. cc @rullzer

[tobiasKaminsky]

Didn't knew this.
To be honest, I am not that sure if this is in line with RFC. I read about REPORT on RCF (https://tools.ietf.org/html/rfc3253#section-3.6) but there is nothing about status.
OTOH we do no have this in PROPFIND.

[MorrisJobke]

To be honest, I am not that sure if this is in line with RFC.

That's why this repo is called 3rdparty 😉

[tobiasKaminsky]

To be honest, I am not that sure if this is in line with RFC.

That's why this repo is called 3rdparty

Do you have any suggestion/idea how to fix this?

[tobiasKaminsky]

@MorrisJobke if we cannot/ do not want to change on server side, I unfortunately do not have any idea how to fix this…

[MorrisJobke]

@rullzer Do you want to bring this upstream?

[kesselb]

@rullzer 🏓

[tobiasKaminsky]

@rullzer ping? :-)

If we do not want to change this, I'll have a look how our new dav library handles this.

[rullzer]

We should fix it upstream.

[tobiasKaminsky]

Can you point me out where I can do this? Or do you want take care of it? ;-)

[rullzer]

https://github.com/sabre-io

[tobiasKaminsky]

Hm. This seems to work now, so closing, but I came across: nextcloud/server#17586