Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queries to Manifest so that lib can find Files App for SDK>=30 #282

Merged
merged 1 commit into from
May 4, 2021

Conversation

tobiasKaminsky
Copy link
Member

Fix #277

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Verified

This commit was signed with the committer’s verified signature.
YOU54F Yousaf Nabi
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky added the 3. to review Waiting for reviews label Nov 16, 2020
@tobiasKaminsky tobiasKaminsky changed the title Add queries to Manifest so that lib can find Fiels App for SDK>=30 Add queries to Manifest so that lib can find Files App for SDK>=30 Nov 16, 2020
@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings33
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings2
Correctness Warnings18
Internationalization Warnings2
Multithreaded correctness Warnings3
Performance Warnings5
Security Warnings5
Dodgy code Warnings11
Total46
<title>Object not found!</title><style type='text/css'></style>

Object not found!

The requested URL was not found on this server. If you entered the URL manually please check your spelling and try again.

If you think this is a server error, please contactthe webmaster.

Error 404

www.kaminsky.me
Apache/2.4.46 (Unix) OpenSSL/1.1.1g

@stefan-niedermann
Copy link
Member

Nice, i will try to test & verify this solution!

Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work (tested with the Deck app).

However i would feel safer if someone (@matiasdelellis or @David-Development ?) could verify this 🙂

@matiasdelellis
Copy link

Hi @stefan-niedermann
I have a user who reported it too. I gladly try it.. However, is there some tagged version or I have to incorporate the library into the code to test it?

@stefan-niedermann
Copy link
Member

@matiasdelellis you can simply use this as dependency:

implementation 'com.github.nextcloud:Android-SingleSignOn:query-SNAPSHOT'

instead of the default SSO dependency.

Ideally you could build the APK with it and provide it to the user who reported it to you, so we can test it with a device which actually has this issue 🙂 (I am only able to test it on emulated devices.... all very theoretically...)

@matiasdelellis
Copy link

Done on matiasdelellis/nextcloud-quicknotes-android#4
I await user feedback.

Thanks. 😄

@stefan-niedermann

This comment has been minimized.

@matiasdelellis

This comment has been minimized.

@matiasdelellis
Copy link

Hi,
I did two PR and I have the report of two users.

matiasdelellis/nextcloud-quicknotes-android#9

  • SingleSignOn:query-SNAPSHOT
  • compileSdkVersion 29
  • minSdkVersion 21
  • Dont set targetSdkVersion. So implicitly at 21 by the above setting.

Both users were able to find the nextcloud client, select the user and use the App.

matiasdelellis/nextcloud-quicknotes-android#10

  • SingleSignOn:query-SNAPSHOT
  • compileSdkVersion 30
  • minSdkVersion 21
  • targetSdkVersion 30

Both users reported the same error. 😞

However, they reported that the client in master also works without the SingleSignOn:query-SNAPSHOT. I will try to inquire into this. 😕

@tobiasKaminsky tobiasKaminsky added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 5, 2021
@tobiasKaminsky
Copy link
Member Author

Any update on this?

stefan-niedermann added a commit to stefan-niedermann/nextcloud-deck that referenced this pull request Apr 19, 2021

Verified

This commit was signed with the committer’s verified signature.
YOU54F Yousaf Nabi
- Raises `targetSdk` to `30`
  - Implements the [necessary `<queries />` to the files app](nextcloud/Android-SingleSignOn#277) since it is not yet merged in the corresponding [SSO pull request](nextcloud/Android-SingleSignOn#282)
- Discards usage of `requestLegacyStorage="true"`
- Replaces the preview of downloaded files in the attachment picker with a direct access to the native system file picker because 
  - `MediaStore` is only able to access files if
    > The files reside in one of the following well-defined media collections: MediaStore.Images, MediaStore.Video, MediaStore.Audio
  ([Source](https://developer.android.com/training/data-storage/shared/media#request-permissions))
  
    ... which is not true for downloaded content.
  - Also the Storage Access Framework [is not able to list content from downloads on Android 11+](https://developer.android.com/training/data-storage/shared/documents-files).
@tobiasKaminsky tobiasKaminsky merged commit c34a817 into master May 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the query branch May 4, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package visibility issue when targetSdk="30"
4 participants