-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queries to Manifest so that lib can find Files App for SDK>=30 #282
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
CodacyLint
SpotBugs (new)
Object not found!The requested URL was not found on this server. If you entered the URL manually please check your spelling and try again. If you think this is a server error, please contactthe webmaster. Error 404www.kaminsky.meApache/2.4.46 (Unix) OpenSSL/1.1.1g |
Nice, i will try to test & verify this solution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work (tested with the Deck app).
However i would feel safer if someone (@matiasdelellis or @David-Development ?) could verify this 🙂
Hi @stefan-niedermann |
@matiasdelellis you can simply use this as dependency:
instead of the default SSO dependency. Ideally you could build the APK with it and provide it to the user who reported it to you, so we can test it with a device which actually has this issue 🙂 (I am only able to test it on emulated devices.... all very theoretically...) |
Done on matiasdelellis/nextcloud-quicknotes-android#4 Thanks. 😄 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi, matiasdelellis/nextcloud-quicknotes-android#9
Both users were able to find the nextcloud client, select the user and use the App. matiasdelellis/nextcloud-quicknotes-android#10
Both users reported the same error. 😞 However, they reported that the client in master also works without the |
Any update on this? |
- Raises `targetSdk` to `30` - Implements the [necessary `<queries />` to the files app](nextcloud/Android-SingleSignOn#277) since it is not yet merged in the corresponding [SSO pull request](nextcloud/Android-SingleSignOn#282) - Discards usage of `requestLegacyStorage="true"` - Replaces the preview of downloaded files in the attachment picker with a direct access to the native system file picker because - `MediaStore` is only able to access files if > The files reside in one of the following well-defined media collections: MediaStore.Images, MediaStore.Video, MediaStore.Audio ([Source](https://developer.android.com/training/data-storage/shared/media#request-permissions)) ... which is not true for downloaded content. - Also the Storage Access Framework [is not able to list content from downloads on Android 11+](https://developer.android.com/training/data-storage/shared/documents-files).
Fix #277
Signed-off-by: tobiasKaminsky tobias@kaminsky.me