Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Bump @nextcloud/vue from 7.0.0-beta.3 to 7.3.0 #1043

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 3, 2023

  • ⚠️ This backport had conflicts and is incomplete

backport of #1035

@backportbot-nextcloud backportbot-nextcloud bot added the dependencies Pull requests that update a dependency file label Jan 3, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.3 milestone Jan 3, 2023
dependabot bot and others added 2 commits January 3, 2023 12:11
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.0.0-beta.3 to 7.3.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v7.0.0-beta.3...v7.3.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@st3iny st3iny force-pushed the backport/1035/stable25 branch from ac3ae68 to 2cfaa19 Compare January 3, 2023 11:12
@st3iny
Copy link
Member

st3iny commented Jan 3, 2023

/compile /

@st3iny
Copy link
Member

st3iny commented Jan 3, 2023

This should fix the focus trap issue, right? cc @szaimen

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Jan 3, 2023

This should fix the focus trap issue, right? cc @szaimen

possibly...

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@st3iny
Copy link
Member

st3iny commented Jan 3, 2023

I did some testing and the activity app does not seem to be affected by the focus trap issue (because it has no popovers/modals). Nevertheless, it might be a good idea to update nc-vue from a beta release.

PS: This branch seems to work just fine.

@st3iny st3iny mentioned this pull request Jan 3, 2023
3 tasks
@nickvergessen nickvergessen merged commit 7850e7f into stable25 Jan 3, 2023
@nickvergessen nickvergessen deleted the backport/1035/stable25 branch January 3, 2023 11:31
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants