-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable25] Bump @nextcloud/vue from 7.0.0-beta.3 to 7.3.0 #1043
Conversation
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.0.0-beta.3 to 7.3.0. - [Release notes](https://github.com/nextcloud/nextcloud-vue/releases) - [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-vue@v7.0.0-beta.3...v7.3.0) --- updated-dependencies: - dependency-name: "@nextcloud/vue" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
ac3ae68
to
2cfaa19
Compare
/compile / |
This should fix the focus trap issue, right? cc @szaimen |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
possibly... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
I did some testing and the activity app does not seem to be affected by the focus trap issue (because it has no popovers/modals). Nevertheless, it might be a good idea to update nc-vue from a beta release. PS: This branch seems to work just fine. |
backport of #1035