-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ActivityTab): vertically center empty content #1733
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
1 failed test on run #1735 ↗︎
Details:
cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E
Review all test suite changes for PR #1733 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! :)
Can you also add before/after screenshots?
Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Edward Ly <contact@edward.ly>
Sorry, I forgot about that, although I am having trouble getting the comments app to behave as expected on my end. This is a screenshot that was provided to me by @marcelklehr: And here is the before and after from my setup.
|
Signed-off-by: Edward Ly <contact@edward.ly>
Red CI is unrelated, merging. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes an issue from a design review for another app that was recently brought to my attention:
-- 8 comments app: The ‘No activity’ text and logo is too close to the input line. Some space is needed
.