Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify file flags #1806

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

stefanschramm
Copy link
Contributor

find . -executable -type f | grep -v "^./.git/hooks" reveals some files that have the executable bit set. I guess this is not necessary.

@artonge
Copy link
Collaborator

artonge commented Oct 8, 2024

@stefanschramm can you fix DCO?

Signed-off-by: Stefan Schramm <mail@stefanschramm.net>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.36%. Comparing base (5e7b446) to head (7c22780).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
- Coverage   31.54%   31.36%   -0.18%     
==========================================
  Files          43       43              
  Lines        1620     1629       +9     
  Branches      110      110              
==========================================
  Hits          511      511              
- Misses       1083     1092       +9     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artonge artonge merged commit 75b8d37 into nextcloud:master Oct 14, 2024
51 of 54 checks passed
@artonge
Copy link
Collaborator

artonge commented Oct 14, 2024

Thanks @stefanschramm :)

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants