-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add RTL support to app heading. #1851
fix: Add RTL support to app heading. #1851
Conversation
e54f4cc
to
eb0de2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1851 +/- ##
=======================================
Coverage 31.36% 31.36%
=======================================
Files 43 43
Lines 1629 1629
Branches 110 110
=======================================
Hits 511 511
Misses 1092 1092
Partials 26 26 ☔ View full report in Codecov by Sentry. |
@falghamdi125, sorry, I forgot to ask you to commit and push the build files. |
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
eb0de2c
to
edeb5a4
Compare
Build files have been added to the commit @artonge |
Thanks a lot @falghamdi125 ! We have a Nextcloud Talk instance where we invite Nextcloud contributors to be able to communicate more quickly. If you like, I could give you a guest account via the email address in your commits? |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
Hello everyone,
This PR adjusts app heading margins and adds support for RTL layouts.
🖼️ Screenshots
💡 Note: This pull request is most effective when the Nextcloud-Vue PR:6260 is approved.
Best