Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prepare() threw \InvalidArgumentException which is deprecated #1859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 20, 2024

If a user has any notifications this log is generated all the time:

OCA\Activity\NotificationGenerator::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link

cypress bot commented Dec 20, 2024

Activity    Run #2130

Run Properties:  status check failed Failed #2130  •  git commit 846e17fccc: fix: prepare() threw \InvalidArgumentException which is deprecated
Project Activity
Branch Review bugfix/noid/notification-handling
Run status status check failed Failed #2130
Run duration 01m 19s
Commit git commit 846e17fccc: fix: prepare() threw \InvalidArgumentException which is deprecated
Committer Joas Schilling
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 8
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has creation activity Test Replay Screenshots
Failed  settings.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant