Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip notifications for users with invalid email address. #448

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Skip notifications for users with invalid email address. #448

merged 1 commit into from
Apr 9, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 4, 2020 •
edited
Loading

Fix nextcloud/server#20294 nextcloud/server#15600

How to test:

  • Have Alice (email: alice@nextcloud.test) and Bob (email: bob).
  • Both are members of group Test
  • Share a folder to group Test
  • Run occ activity:send-mails
  • We are able to send the notification for Alice but for Bob it fails with something like

image

  • Run occ activity:send-mails again
  • See the notification for Alice is sent a second time

The faulty code is actual at https://github.com/nextcloud/server/blob/1a9330cd69631ef12b71239c4f98836e09e021ea/lib/private/Mail/Message.php#L82-L83. We might fix that by just deleting Message::convertAddresses and Mailer::convertEmail method because SwiftMailer supports IDN nowdays.

@kesselb kesselb requested a review from nickvergessen April 4, 2020 18:24
@kesselb kesselb added this to the Nextcloud 19 milestone Apr 4, 2020
@kesselb
Skip notifications for users with invalid email address.
220c68a 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/20294/skip-notification-for-invalid-email branch from b0eedb9 to 220c68a Compare April 4, 2020 19:43
@kesselb kesselb mentioned this pull request Apr 4, 2020
Closed
@rullzer rullzer mentioned this pull request Apr 7, 2020
Merged
80 tasks
@nickvergessen nickvergessen merged commit 82e1a4d into master Apr 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/20294/skip-notification-for-invalid-email branch April 9, 2020 09:10
@nickvergessen
Copy link
Member

/backport to stable18

@nickvergessen
Copy link
Member

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 9, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #449

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 9, 2020
Closed
@backportbot-nextcloud
Copy link

backport to stable17 in #450

@rullzer rullzer mentioned this pull request Apr 9, 2020
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

Malformed mail address causes notification mail loop
2 participants
@kesselb @nickvergessen