Notify groupmates also when renaming and moving files (by using Group folders app) #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
ghost
force-pushed
the
update/group_users_notifications
branch
from
a1677c3
to
843f830
Compare
|
Hi @nickvergessen ! |
ghost
force-pushed
the
update/group_users_notifications
branch
from
843f830
to
84f5180
Compare
Signed-off-by: Chris Fritsche <chris.fritsche@cunio.de> adjusts from PR review adjust notifications by moving
ghost
force-pushed
the
update/group_users_notifications
branch
from
84f5180
to
605615d
Compare
ghost
mentioned this pull request
|
Partly solves nextcloud/groupfolders#1018. |
|
@chrisfritsche @nickvergessen Would you mind to respin this and bring it over the finish line? |
|
Fine by me. I'm time limited and won't be able to do it myself. |
|
Here is a follow-up PR: #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
Groupmates (using Group folders app) are only notified when a file is created.
With this PR:
Notify groupmates also when renaming and moving.
Thanks in advance for a feedback.