-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the sidebar tab in Vue #581
Conversation
6d448c6
to
b822f34
Compare
src/components/richArgumentsTypes/CalendarEventRichArgument.vue
Outdated
Show resolved
Hide resolved
1fe536e
to
f4d8369
Compare
f4d8369
to
5c7f731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments :)
Looks great!
Let's ping Jan for design update, now this is the time to do that 🚀
src/components/richArgumentsTypes/CalendarEventRichArgument.vue
Outdated
Show resolved
Hide resolved
5c7f731
to
8a74a11
Compare
Nice nice @artonge! :) 2 things from the design side:
|
8a74a11
to
9fffa1e
Compare
UI update:
I felt the opposite, I felt that they were to small previously, they felt "cheap" to me compared to the Sharing and Comments tab. Maybe we could match those ?
Indeed.
Added an example with a comment from another user. It seems duplicate to change the icon comment to the user's avatar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woho, I made 3 attempts to migrate the normal activity view to Vue, but always failed to finish it completely.
This looks like a step into the future :)
Please let's not do this here. This needs fixing on various levels and should be reflected via the API so it works in the mobile apps then too. |
8268e4b
to
751d91f
Compare
751d91f
to
6e0430d
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me Signed-off-by: Louis Chemineau <louis@chmn.me>
3fd6dd9
to
acd0974
Compare
acd0974
to
a5ae3f7
Compare
a50d454
to
ddd3acc
Compare
a629006
to
645a662
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
645a662
to
6cb4ee3
Compare
This is a rewrite in Vue of the sidebar tab.
I used
@juliushaertl/vue-richtext
to render activities, and created components for activity types that needed it.Done: