tini

[Zoey2936]

please read this: https://petermalmgren.com/signal-handling-docker

[szaimen]

Would this mean that we would need to use tini for all containrs? Currently I think it also works quite nice without using it so should we actually switch to it?

[Zoey2936]

all containsers, which don't launch directly supervisor and all container which launch a shell script and then supervisor, and I think all containers match these points, so yes I would add it to all, I will also do this with all my Dockerfiles

[Zoey2936]

we just need to install tini in all containers (apt/apk) and then add at the begining of the entrypoint option in the docker file ["tini", "--", and if we just use cmd (no entrypoint) inside that dockerfile using ["tini", "--"] as entrypoint without changing the cmd is enough. Or we do this: https://docs.docker.com/engine/reference/run/#specify-an-init-process but not sure if the containers.json supports that, for the mastercontainer we need to do it manually in the Dockerfile since compose does not support it

[szaimen]

I still don't see why we need this? What could happen if we leave things like they are currently?
(I am open for doing this if there is a good reason) :)

[szaimen]

docker-compose seems to support this as well: https://docs.docker.com/compose/compose-file/compose-file-v3/#init

[szaimen]

Do you think we can simply use this?

[Zoey2936]

so we add --init / init: true to the docker run command/compose file? and for all other containers we add it to the containers.json?

[szaimen]

so we add --init / init: true to the docker run command/compose file? and for all other containers we add it to the containers.json?

Yes, I would say so :)

[Zoey2936]

since I have no idea about the containers.json, can you please do it?

[szaimen]

Will be done in #3140