-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker permission issues #17
Conversation
Signed-off-by: Adrian Gebhart <adrian@pestotoast.de>
3200cc7
to
2371dfd
Compare
@szaimen WDYT? :) |
@pestotoast Thank you for your PR! I just discussed with @LukasReschke that your PR makes sense. I'll test it and update it if needed later on. Please make sure to allow edit by the maintainers for your branch, if not already done. Thanks! :) |
Signed-off-by: szaimen <szaimen@e.mail.de>
d4b18c3
to
01e8e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I'll test this now on the develop channel
Unfortunately those new changes don't work for me. I get a permission denied error now:
But after the login I get:
My guess is that it's another permission error with docker now. Apache still seems to run as |
Yes, thanks for testing! I've just seen the problem, too. Will fix it in #33. Fortunately it isn't deployed to latest, yet. |
This should fix #10
The start.sh script of the mastercontainer now runs with root privileges so we can manage group permissions during startup.
I adjusted the supervisor.conf of the mastercontainer so that all other processes still run as www-data, but had some issues with log file permissions, thats why I removed some logging options from the supervisor.conf. (Do we need them?)