update opcache settings

[szaimen]

Fix #192

Signed-off-by: szaimen szaimen@e.mail.de

[szaimen]

@MichaIng does this look good to you or do wee need to keep setting opcache.interned_strings_buffer to a higher value than 8?

[MichaIng]

Generally looks fine, given that the other settings are PHP defaults anyway. Is there a way for users to pass overrides for PHP settings, i.e. that there is the possibility to increase interned strings buffer when needed? Else probably using 16 to mute the warning in more cases is reasonable. The interned strings buffer is allocated as part of the 128 MiB overall OPcache size, and given that Nextcloud is using only something between 32 and 64 MiB, there is not an issue with allocation some more for the interned strings buffer.

[szaimen]

Thanks for your review and answer! Since there is currently no way to adjust this for the user, I'll use 16 as value for the opcache.interned_strings_buffer.

[juliusknorr]

Makes sense, thanks also for the good insight on the issue @MichaIng

Should we maybe also adapt our default recommendations in the documentation then a bit?

[szaimen]

Thanks for the review julius!

[szaimen]

Should we maybe also adapt our default recommendations in the documentation then a bit?

I think it is already adjusted...

[MichaIng]

Since Apache2 is used as webserver, when mod_php (instead of PHP-FPM) is used, a custom config snippet with php_admin_value opcache.interned_strings_buffer "16" would be possible as well, when that is possible to pass to the container.

The docs are already adjusted, but we could add the hint that in some cases a higher than default interned strings buffer is required/recommended, in addition to what the admin panel shows. So admins are made aware of this in the first place, respectively can verify that the admin panel warning is not so unexpected when following the link shown on the admin panel as well.