Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set NEXTCLOUD_MOUNT to rshared #2601

Merged
merged 1 commit into from
Jul 20, 2023
Merged

set NEXTCLOUD_MOUNT to rshared #2601

merged 1 commit into from
Jul 20, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented May 26, 2023 •
edited
Loading

Close #2585

Address #2927

@szaimen szaimen added the 2. developing Work in progress label May 26, 2023
@szaimen szaimen added this to the next milestone May 26, 2023
@szaimen szaimen force-pushed the enh/2585/volume-mounts branch 2 times, most recently from 4d72196 to c5f0e01 Compare May 26, 2023 10:14
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request and removed 2. developing Work in progress labels May 26, 2023
@szaimen szaimen marked this pull request as ready for review May 26, 2023 10:14
@szaimen szaimen changed the title set volume mounts to rshared set bind mounts to rshared May 26, 2023
@szaimen szaimen modified the milestones: v5.2.2, next May 26, 2023
@szaimen szaimen mentioned this pull request May 26, 2023
Closed
31 tasks
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 30, 2023
@szaimen szaimen marked this pull request as draft May 30, 2023 13:32
@szaimen szaimen removed this from the next milestone May 30, 2023
@szaimen szaimen modified the milestones: next, v6.1.0, v6.1.1 Jun 6, 2023
@szaimen szaimen added the help wanted Extra attention is needed label Jun 13, 2023
@szaimen szaimen removed this from the next milestone Jun 16, 2023
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 24, 2023 •
edited
Loading

Hm... maybe the documentation is actually wrong? (would need to be tested)
docker/for-win#11958 (comment)

not it doesnt:
image

@Zoey2936 Zoey2936 mentioned this pull request Jul 8, 2023
Closed
@szaimen
Copy link
Collaborator Author

szaimen commented Jul 10, 2023

One possible way would be to only use this logic for NEXTCLOUD_MOUNT and not for others.

@szaimen szaimen added this to the next milestone Jul 10, 2023
@szaimen szaimen mentioned this pull request Jul 10, 2023
Closed
35 tasks
@szaimen szaimen removed this from the v6.3.0 milestone Jul 14, 2023
@szaimen szaimen added this to the next milestone Jul 14, 2023
@szaimen szaimen mentioned this pull request Jul 19, 2023
Closed
24 tasks
@szaimen szaimen force-pushed the enh/2585/volume-mounts branch 2 times, most recently from 3348450 to 3aab293 Compare July 19, 2023 13:37
@szaimen
set NEXTCLOUD_MOUNT to rshared
7824060 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/2585/volume-mounts branch from 3aab293 to 7824060 Compare July 19, 2023 13:40
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted Extra attention is needed labels Jul 19, 2023
@szaimen szaimen marked this pull request as ready for review July 19, 2023 13:41
@szaimen szaimen changed the title set bind mounts to rshared set NEXTCLOUD_MOUNT to rshared Jul 19, 2023
@szaimen szaimen merged commit 00557fe into main Jul 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/2585/volume-mounts branch July 20, 2023 14:07
@reply-nick
Copy link

@szaimen after this change, I am getting this error:
Message: Server error: `POST http://localhost/v1.41/containers/nextcloud-aio-nextcloud/start` resulted in a `500 Internal Server Error` response: {&quot;message&quot;:&quot;path /mnt is mounted on / but it is not a shared mount&quot;}

my data folder is on a NFS share.
Are there any workarounds for this?

@reply-nick reply-nick mentioned this pull request Jul 30, 2023
Closed
@Franz36 Franz36 mentioned this pull request Aug 16, 2023
Closed
szaimen added a commit that referenced this pull request Jun 3, 2024
@szaimen
revert "set NEXTCLOUD_MOUNT to rshared #2601"
9387c1c 
as it causes too many problems.

Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen added a commit that referenced this pull request Jun 6, 2024
@szaimen
Merge pull request #4755 from nextcloud/revert/2601/due-too-many-fail…
77694bf 
…ures

revert "set NEXTCLOUD_MOUNT to rshared #2601"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatziko chatziko chatziko left review comments

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @reply-nick @chatziko