Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note about SELinux and Docker Desktop #2670

Merged
merged 2 commits into from
Jun 6, 2023
Merged

add note about SELinux and Docker Desktop #2670

merged 2 commits into from
Jun 6, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jun 5, 2023 •
edited
Loading

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Jun 5, 2023
@szaimen szaimen added this to the next milestone Jun 5, 2023
@szaimen szaimen requested a review from Zoey2936 June 5, 2023 09:08
@szaimen
add note about SELinux and Docker Desktop
aac2ad1 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/add-note-about-selinux branch from 0d68f06 to aac2ad1 Compare June 5, 2023 09:10
@szaimen szaimen added the documentation Improvements or additions to documentation label Jun 5, 2023
@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 5, 2023

maybe also add this option commented to the compose file

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 5, 2023

also not sure if privileged or security opt is better

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023 •
edited
Loading

also not sure if privileged or security opt is better

I think privileged is the last resort so I would say security opt is more secure.

@szaimen
address review
852a80d 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

maybe also add this option commented to the compose file

I would leave it out for now. If the question comes up more often after adding this doc, we can still adjust the compose.yaml later on.

@szaimen szaimen requested a review from Zoey2936 June 5, 2023 09:57
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

also not sure if privileged or security opt is better

I think privileged is the last resort so I would say security opt is more secure.

image

From https://danwalsh.livejournal.com/74095.html

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 5, 2023

ahh I see

@szaimen szaimen merged commit 1446c31 into main Jun 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/add-note-about-selinux branch June 6, 2023 07:28
@szaimen szaimen mentioned this pull request Jun 6, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoey2936 Zoey2936 Zoey2936 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@szaimen @Zoey2936