Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for timezone #3153

Merged
merged 2 commits into from
Aug 17, 2023
Merged

add check for timezone #3153

merged 2 commits into from
Aug 17, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Aug 14, 2023

Close #3147

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Aug 14, 2023
@szaimen szaimen added this to the next milestone Aug 14, 2023
@szaimen szaimen requested a review from Zoey2936 August 14, 2023 10:01
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/3147/add-timezone-check branch from 869c55a to 35c08c0 Compare August 14, 2023 10:02
@Zoey2936
Copy link
Collaborator

maybe also mention, that the timezone should be set inside the aio panel

@Zoey2936
Copy link
Collaborator

and also is doing exit 1 a good idea?

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 14, 2023

maybe also mention, that the timezone should be set inside the aio panel

Good idea!

and also is doing exit 1 a good idea?

Yes, I don't think many instances have set this. If there should be many reports, we can still remove the exit later.

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen requested review from Zoey2936 and removed request for Zoey2936 August 14, 2023 10:41
@szaimen szaimen merged commit 43b5a7c into main Aug 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/3147/add-timezone-check branch August 17, 2023 07:40
@captaindyson
Copy link

This change has caused issues on Unraid. the os adds a TZ to all docker run commands by default, hence preventing the running of the container.
Manualy adding a TZ variable with no value seems to override this, but is not ideal, or at least will require clearly communicating.

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 4, 2023

Interesting! I guess we will need to fix this then in order to not break all unraid instances.

@szaimen szaimen mentioned this pull request Sep 4, 2023
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 5, 2023

This change has caused issues on Unraid. the os adds a TZ to all docker run commands by default, hence preventing the running of the container.

This is now fixed with v7.1.1 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

@captaindyson
Copy link

Can confirm this has fixed the issue, warning remains in the logs, but the container starts anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants