Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eturnal - set blacklist_peers #3426

Merged
merged 2 commits into from
Sep 28, 2023
Merged

eturnal - set blacklist_peers #3426

merged 2 commits into from
Sep 28, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Sep 27, 2023

Close #3395
Close #3472
Close #3483

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Sep 27, 2023
@szaimen szaimen added this to the next milestone Sep 27, 2023
@szaimen szaimen requested a review from Zoey2936 September 27, 2023 18:27
@sando38
Copy link

sando38 commented Sep 27, 2023

You may drop

  blacklist_peers:
  - recommended

entirely, because it (will be)/ is the default value.

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 27, 2023

All right but I think I would keep it for the sake of being more verbose here. Also we use whitelist_peers...

@sando38
Copy link

sando38 commented Sep 27, 2023

All right but I think I would keep it for the sake of being more verbose here. Also we use whitelist_peers...

Sure. Ask the guys in the discussion threads, if this works during your beta/RC tests. If not, you still may need to add an option to define further whitelisted IP addresses/ranges.

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 27, 2023

Sure. Ask the guys in the discussion threads, if this works during your beta/RC tests

I will but I guess I still need for eturnal/eturnal:1.12.0 to get released?

@sando38
Copy link

sando38 commented Sep 27, 2023

Sure. Ask the guys in the discussion threads, if this works during your beta/RC tests

I will but I guess I still need for eturnal/eturnal:1.12.0 to get released?

Definitely. https://github.com/erlang/docker-erlang-otp has not released erlang 26.1, yet... so we may wait for another one, two days and if not available, we fall back to 26.0.2, which does not change anything in regard to functionality, security, whatever.

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 27, 2023

Definitely. erlang/docker-erlang-otp has not released erlang 26.1, yet... so we may wait for another one, two days and if not available, we fall back to 26.0.2, which does not change anything in regard to functionality, security, whatever.

All right 👍

@weiss
Copy link

weiss commented Sep 28, 2023

We've now published eturnal 1.12.0, which supports the blacklist_peers thing.

(Greetings from Steglitz!)

@szaimen
Copy link
Collaborator Author

szaimen commented Sep 28, 2023

We've now published eturnal 1.12.0, which supports the blacklist_peers thing.

(Greetings from Steglitz!)

Thank you! Greetings back! :)

@szaimen szaimen merged commit a53f7b4 into main Sep 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/3395/eturnal branch September 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants