Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NPMplus as community-container #3520

Merged
merged 12 commits into from
Oct 16, 2023
Merged

Add NPMplus as community-container #3520

merged 12 commits into from
Oct 16, 2023

Conversation

Zoey2936
Copy link
Collaborator

@Zoey2936 Zoey2936 commented Oct 9, 2023

No description provided.

@Zoey2936
Add NPMplus as community-container
3bca146 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936 Zoey2936 requested a review from szaimen October 9, 2023 20:12
@Zoey2936 Zoey2936 self-assigned this Oct 9, 2023
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Oct 9, 2023
@szaimen szaimen added this to the next milestone Oct 9, 2023
szaimen
szaimen reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! Looks already pretty good! :)

Just a few small comments...

community-containers/npmplus/npmplus.json Show resolved Hide resolved
community-containers/npmplus/readme.md Outdated Show resolved Hide resolved
community-containers/npmplus/readme.md Outdated Show resolved Hide resolved
community-containers/npmplus/readme.md Show resolved Hide resolved
community-containers/npmplus/readme.md Show resolved Hide resolved
@Zoey2936
backup volume
5d159ae 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936
mention incompatibilitys
34a3433 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936 Zoey2936 requested a review from szaimen October 10, 2023 11:13
@Zoey2936
Update readme.md
b7cc669 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936
port 81 is tcp
827f4e1 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936
remove listen localhost
20f0815 
Signed-off-by: Zoey <zoey@z0ey.de>
szaimen and others added 3 commits October 10, 2023 14:22
@szaimen
add warning regarding npmplus to caddy community container
9008534 
Signed-off-by: Simon L <szaimen@e.mail.de>
@Zoey2936
disable http
6387996 
Signed-off-by: Zoey <zoey@z0ey.de>
@szaimen
add caddy notice to top
c402021 
Signed-off-by: Simon L <szaimen@e.mail.de>
@Zoey2936
Update readme.md
8d03882 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936
AIO mode already disables HTTP
1a7b69f 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936
Update readme.md
1db7ead 
Signed-off-by: Zoey <zoey@z0ey.de>
@Zoey2936 Zoey2936 requested a review from szaimen October 10, 2023 14:01
szaimen
szaimen approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to wait for the next stable release

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2023
@szaimen szaimen merged commit a846b46 into main Oct 16, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the community-container-npmplus branch October 16, 2023 08:40
@szaimen
Copy link
Collaborator

szaimen commented Oct 20, 2023

This is now released with v7.5.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@Zoey2936 Zoey2936

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zoey2936 @szaimen