add maxconn value to haproxy #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Zoey2936
reviewed
Oct 19, 2023
| @@ -1,5 +1,8 @@ | |||
| # Inspiration: https://github.com/Tecnativa/docker-socket-proxy/blob/master/haproxy.cfg | |||
|
|
|||
| global | |||
| maxconn 2000 | |||
There was a problem hiding this comment.
is there are reason for using this number?
There was a problem hiding this comment.
do you know how many connection Appapi uses?
There was a problem hiding this comment.
@andrey18106 @bigcat88 do you know?
There was a problem hiding this comment.
Is it that necessary? AppAPI uses connection to daemon only during administration actions
There was a problem hiding this comment.
Apparently maxconn is needed on some system. See #3566
There was a problem hiding this comment.
It would be enough with reserve set it to 10 I guess.
There was a problem hiding this comment.
all right. adjusted.
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
fix/3566/fix-haproxy
branch
from
62a6a31 to
36acb8e
Compare
andrey18106
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3566