nextcloud container - allowed clients - only limit access in known use cases #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Zoey2936
requested changes
Oct 20, 2023
So do you have a better idea then how to fix #3540? |
|
No, but if we whitelist the gateway, we could also allow all ips.... |
szaimen
force-pushed
the
enh/3540/fix-rp-setup
branch
from
805129a to
3c2296c
Compare
szaimen
changed the title
szaimen
force-pushed
the
enh/3540/fix-rp-setup
branch
from
3c2296c to
a6b0e0e
Compare
szaimen
force-pushed
the
enh/3540/fix-rp-setup
branch
3 times, most recently
from
5ab36ba to
28e8257
Compare
…e cases Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/3540/fix-rp-setup
branch
from
28e8257 to
c5135e3
Compare
szaimen
commented
Oct 20, 2023
| sed -i "/^listen.allowed_clients/s/,$//" /usr/local/etc/php-fpm.d/www.conf | ||
| grep listen.allowed_clients /usr/local/etc/php-fpm.d/www.conf | ||
| set -x | ||
| if [ "$APACHE_PORT" = 443 ] || [ "$APACHE_IP_BINDING" = "127.0.0.1" ] || [ "$APACHE_IP_BINDING" = "::1" ]; then |
There was a problem hiding this comment.
@Zoey2936 this is most important. I decided based on your comment to only limit it if AIO runs in normal mode or the reverse proxy runs in the host network of the server that runs AIO. For these recommended cases we limit the access. Does this make sense?
|
@Zoey2936 if you are fine with this PR, I would like to merge this and create a new beta release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3540
This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/3574/files?w=1