Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scorecard.yml #47

Merged
merged 5 commits into from
Feb 13, 2023
Merged

add scorecard.yml #47

merged 5 commits into from
Feb 13, 2023

Conversation

tobiasKaminsky
Copy link
Member

@AlvaroBrey shall we then also enabled this for this repo?
If so, we would need to change sync.yml and also add this repo?

@tobiasKaminsky tobiasKaminsky added the 3. to review Waiting for reviews label Feb 13, 2023
AlvaroBrey
AlvaroBrey requested changes Feb 13, 2023
View reviewed changes
config/workflows/scorecard.yml Outdated Show resolved Hide resolved
config/workflows/scorecard.yml Outdated Show resolved Hide resolved
config/workflows/scorecard.yml Outdated Show resolved Hide resolved
@AlvaroBrey
Copy link
Member

AlvaroBrey commented Feb 13, 2023 •
edited
Loading

If so, we would need to change sync.yml and also add this repo?

We could, but it can't just be added to the list of the other repos, as those currently sync all workflows in config/workflows, and this repo doesn't need all of the android stuff. Either way it can be done, if you want to.

@AlvaroBrey
sync.yml: sync scorecard action to this same repo
1c4fcbd 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey
Copy link
Member

If so, we would need to change sync.yml and also add this repo?

We could, but it can't just be added to the list of the other repos, as those currently sync all workflows in config/workflows, and this repo doesn't need all of the android stuff. Either way it can be done, if you want to.

Done at 1c4fcbd

tobiasKaminsky and others added 3 commits February 13, 2023 11:19
@tobiasKaminsky @AlvaroBrey
Update config/workflows/scorecard.yml
c24def4 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
@tobiasKaminsky @AlvaroBrey
Update config/workflows/scorecard.yml
f286242 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
@tobiasKaminsky @AlvaroBrey
Update config/workflows/scorecard.yml
119b6ff 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
@AlvaroBrey AlvaroBrey enabled auto-merge February 13, 2023 10:22
@AlvaroBrey AlvaroBrey merged commit b0d7fc7 into main Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the scanner branch February 13, 2023 10:24
@AlvaroBrey
Copy link
Member

When this is synced to android-library we'll need to remove the old workflow, as it is called scorecards.yml instead of scorecard.yml

@tobiasKaminsky
Copy link
Member Author

Nice catch!
nextcloud/android-library#1066

@AlvaroBrey AlvaroBrey mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @AlvaroBrey