do not use context as field

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
nextcloud · Jan 24, 2024 · fe5b7b4 · fe5b7b4
1 parent cd72cda
commit fe5b7b4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/library/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java b/library/src/main/java/com/owncloud/android/lib/common/OwnCloudClient.java
@@ -74,7 +74,7 @@ public class OwnCloudClient extends HttpClient {
     private OwnCloudCredentials credentials = null;
     private int mInstanceNumber;
 
-    private final Context context;
+    private AdvancedX509KeyManager keyManager;
 
     /**
      * Constructor
@@ -85,7 +85,7 @@ public OwnCloudClient(Uri baseUri, HttpConnectionManager connectionMgr, Context
         if (baseUri == null) {
         	throw new IllegalArgumentException("Parameter 'baseUri' cannot be NULL");
         }
-        this.context = context;
+        this.keyManager = new AdvancedX509KeyManager(context);
         nextcloudUriDelegate = new NextcloudUriDelegate(baseUri);
 
         mInstanceNumber = sInstanceCounter++;
@@ -165,7 +165,7 @@ public int executeMethod(HttpMethodBase method, int readTimeout, int connectionT
             if (httpStatus == HttpStatus.SC_BAD_REQUEST) {
                 URI uri = method.getURI();
                 Log_OC.e(TAG, "Received http status 400 for " + uri + " -> removing client certificate");
-                new AdvancedX509KeyManager(context).removeKeys(uri);
+                keyManager.removeKeys(uri);
             }
             return httpStatus;
         } finally {
@@ -205,7 +205,7 @@ public int executeMethod(HttpMethod method) throws IOException {
             } else if (status == HttpStatus.SC_BAD_REQUEST) {
                 URI uri = method.getURI();
                 Log_OC.e(TAG, "Received http status 400 for " + uri + " -> removing client certificate");
-                new AdvancedX509KeyManager(context).removeKeys(uri);
+                keyManager.removeKeys(uri);
             }
 
             if (followRedirects) {