Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump targetSdkVersion to 32 #1003

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Bump targetSdkVersion to 32 #1003

merged 1 commit into from
Nov 24, 2022

Conversation

AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Nov 23, 2022

Fixes #1002

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1003 (8b9fb80) into master (b106f71) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   48.98%   48.98%           
=======================================
  Files         178      178           
  Lines        6686     6686           
  Branches      886      886           
=======================================
  Hits         3275     3275           
  Misses       2940     2940           
  Partials      471      471           

@tobiasKaminsky
Copy link
Member

Seems to work with Files app.

@AlvaroBrey AlvaroBrey marked this pull request as ready for review November 24, 2022 09:15
@AlvaroBrey AlvaroBrey merged commit 796d949 into master Nov 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the chore/sdk-32 branch November 24, 2022 09:16
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.14.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump targetSdk to 32
2 participants