Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase wait time for wait_for_server #1039

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Jan 17, 2023

This script waits for the server to wake up during CI before launching tests.
In this library it only waited for 100 seconds instead of the 500 seconds it waits in the Files app.

This caused "failed to wait for server" in some occasions where the server image needs to be downloaded
and there's slow internet or poor performance.

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

This script waits for the server to wake up during CI before launching tests.
In this library it only waited for 100 seconds instead of the 500 seconds it waits in the Files app.

This caused "failed to wait for server" in some occasions where the server image needs to be downloaded
and there's slow internet or poor performance.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey AlvaroBrey force-pushed the chore/wait-server-longer branch from e7dd7a3 to 974228a Compare January 17, 2023 08:56
@AlvaroBrey AlvaroBrey changed the title Copy wait_for_server from Files app for parity and longer wait. Increase wait time for wait_for_server Jan 17, 2023
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@AlvaroBrey AlvaroBrey merged commit 15b318d into master Jan 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the chore/wait-server-longer branch January 17, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants