🔄 synced file(s) with nextcloud/android-config

[nextcloud-android-bot]

synced local file(s) with nextcloud/android-config.

Changed files

• synced local directory .github/workflows/ with remote directory config/workflows/

---

This PR was created automatically by the repo-file-sync-action workflow run #4130440582

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[AlvaroBrey]

Hm, wonder why autoApproveSync didn't auto-approve this...

[tobiasKaminsky]

https://github.com/nextcloud/android-library/pull/1060/files#diff-6b1d85d966f42158a4b9a760099731a1576d5b4074afebadf11d9f4c4f1b5543L13

It only checks for dependabot as author, but this PR was created by nextcloud-android-bot.

[AlvaroBrey]

https://github.com/nextcloud/android-library/pull/1060/files#diff-6b1d85d966f42158a4b9a760099731a1576d5b4074afebadf11d9f4c4f1b5543L13

It only checks for dependabot as author, but this PR was created by nextcloud-android-bot.

autoApproveSync is a different workflow: https://github.com/nextcloud/android-library/actions/runs/4130482885/jobs/7140806969

##[debug]Evaluating: (success() && contains(github.event.pull_request.labels[*].name, 'sync') && (github.actor == 'nextcloud-android-bot'))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating contains:
##[debug]....Evaluating Index:
##[debug]......Evaluating Index:
##[debug]........Evaluating Index:
##[debug]..........Evaluating Index:
##[debug]............Evaluating Index:
##[debug]..............Evaluating github:
##[debug]..............=> Object
##[debug]..............Evaluating String:
##[debug]..............=> 'event'
##[debug]............=> Object
##[debug]............Evaluating String:
##[debug]............=> 'pull_request'
##[debug]..........=> Object
##[debug]..........Evaluating String:
##[debug]..........=> 'labels'
##[debug]........=> Array
##[debug]........Evaluating Wildcard:
##[debug]........=> '*'
##[debug]......=> Array
##[debug]......Evaluating String:
##[debug]......=> 'name'
##[debug]....=> Array
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && contains(Array, 'sync') && (github['actor'] == 'nextcloud-android-bot'))
##[debug]Result: false

Looks like at the moment the PR ran, the sync label was not present (or I wrote the condition wrong, I wish I could test this properly).

[AlvaroBrey]

Looks like at the moment the PR ran, the sync label was not present

Ah, in fact this looks correct from the github UI: the sync action first opened the PR and then added the label. Which means when this workflow ran on PR opening, the label was not there yet. I'll add a workaround for this in the config.