Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin deps #1064

Merged
merged 1 commit into from
Feb 28, 2023
Merged

pin deps #1064

merged 1 commit into from
Feb 28, 2023

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Feb 13, 2023
View reviewed changes
@AlvaroBrey AlvaroBrey enabled auto-merge February 13, 2023 08:46
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.15.0 milestone Feb 13, 2023
@AlvaroBrey AlvaroBrey disabled auto-merge February 28, 2023 10:13
@tobiasKaminsky @AlvaroBrey
pin deps
ea5f791 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1064 (ea5f791) into master (a81326f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1064   +/-   ##
=======================================
  Coverage   51.09%   51.09%           
=======================================
  Files         180      180           
  Lines        6754     6754           
  Branches      898      898           
=======================================
  Hits         3451     3451           
  Misses       2817     2817           
  Partials      486      486

@AlvaroBrey AlvaroBrey merged commit 1cfc1c6 into master Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the deps branch February 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey left review comments

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
NC Android Lib 2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @AlvaroBrey