Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resultData #1114

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Use resultData #1114

merged 2 commits into from
Jun 2, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Apr 20, 2023 •
edited by AndyScherzinger
Loading

Client adapted in nextcloud/android#11546

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 39
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 134

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@tobiasKaminsky tobiasKaminsky mentioned this pull request Apr 20, 2023
Merged
1 task
@AndyScherzinger AndyScherzinger added this to the NC Android Lib 2.15.0 milestone May 14, 2023
@nextcloud nextcloud deleted a comment from github-actions bot May 26, 2023
@nextcloud nextcloud deleted a comment from github-actions bot May 26, 2023
@AndyScherzinger AndyScherzinger force-pushed the remoteOperation branch 2 times, most recently from ab34abb to f42f616 Compare May 27, 2023 13:46
@nextcloud nextcloud deleted a comment from github-actions bot May 27, 2023
@nextcloud nextcloud deleted a comment from github-actions bot May 27, 2023
@nextcloud nextcloud deleted a comment from github-actions bot May 27, 2023
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@AndyScherzinger
Copy link
Member

@tobiasKaminsky your newly added test fails 😢 #1114 (comment)

@github-actions github-actions bot deleted a comment from nextcloud-android-bot Jun 1, 2023
@github-actions github-actions bot deleted a comment from nextcloud-android-bot Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@nextcloud nextcloud deleted a comment from github-actions bot Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #1114 (1f0acbd) into master (c4c4a2c) will increase coverage by 0.84%.
The diff coverage is 41.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
+ Coverage   52.14%   52.98%   +0.84%     
==========================================
  Files         187      187              
  Lines        6937     6924      -13     
  Branches      914      914              
==========================================
+ Hits         3617     3669      +52     
+ Misses       2818     2743      -75     
- Partials      502      512      +10
Impacted Files Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 46.62% <ø> (+1.32%) ⬆️
...egisterAccountDeviceForNotificationsOperation.java 0.00% <0.00%> (ø)
.../notifications/GetNotificationRemoteOperation.java 66.66% <66.66%> (+66.66%) ⬆️
...notifications/GetNotificationsRemoteOperation.java 64.51% <75.00%> (+64.51%) ⬆️

... and 5 files with indirect coverage changes

@tobiasKaminsky @AndyScherzinger
Use resultData
0708411 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
fix test
1f0acbd 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 36
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 110

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 29
Internationalization Warnings 6
Malicious code vulnerability Warnings 40
Multithreaded correctness Warnings 3
Performance Warnings 4
Dodgy code Warnings 25
Total 116

@AndyScherzinger AndyScherzinger merged commit ca6ce2e into master Jun 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the remoteOperation branch June 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review client change required
Projects
None yet
Milestone
NC Android Lib 2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @AndyScherzinger