Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Nullability of OCS Remote Operation #1289

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Dec 26, 2023

getServerResponse function may return null value. Library must handle nullable value to potential prevent crashes.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Merging #1289 (eec0e57) into master (012db19) will increase coverage by 3.72%.
The diff coverage is 58.44%.

❗ Current head eec0e57 differs from pull request most recent head 92002cc. Consider uploading reports for the commit 92002cc to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1289      +/-   ##
============================================
+ Coverage     48.57%   52.30%   +3.72%     
- Complexity      977      978       +1     
============================================
  Files           200      192       -8     
  Lines          7697     7114     -583     
  Branches        989      949      -40     
============================================
- Hits           3739     3721      -18     
+ Misses         3438     2863     -575     
- Partials        520      530      +10     
Files Coverage Δ
...ncloud/android/lib/resources/OCSRemoteOperation.kt 100.00% <100.00%> (ø)
...ctEditingObtainListOfTemplatesRemoteOperation.java 62.96% <71.42%> (-5.04%) ⬇️
...ectediting/DirectEditingObtainRemoteOperation.java 60.00% <75.00%> (-3.64%) ⬇️
...esources/users/ConvertAppTokenRemoteOperation.java 73.91% <60.00%> (-7.91%) ⬇️
...es/users/GetPredefinedStatusesRemoteOperation.java 55.00% <60.00%> (-10.00%) ⬇️
.../lib/resources/users/GetStatusRemoteOperation.java 60.86% <60.00%> (-7.32%) ⬇️
...s/dashboard/DashboardListWidgetsRemoteOperation.kt 65.00% <40.00%> (-12.78%) ⬇️
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt 60.00% <40.00%> (-8.97%) ⬇️
...b/resources/profile/GetHoverCardRemoteOperation.kt 55.55% <62.50%> (-9.83%) ⬇️
...ashboard/DashboardGetWidgetItemsRemoteOperation.kt 65.38% <42.85%> (-12.88%) ⬇️
... and 2 more

... and 42 files with indirect coverage changes

@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch 2 times, most recently from ffd1f7f to eec0e57 Compare January 9, 2024 11:27
@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch 4 times, most recently from fd91e34 to cd82b7a Compare February 7, 2024 08:07
@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch from cd82b7a to 443c7b5 Compare February 12, 2024 09:11
@AndyScherzinger AndyScherzinger force-pushed the fix/Check-Nullability-OCSRemoteOperation branch from 443c7b5 to 7e4f691 Compare February 12, 2024 22:04
@AndyScherzinger AndyScherzinger force-pushed the fix/Check-Nullability-OCSRemoteOperation branch from 7e4f691 to f211942 Compare February 13, 2024 07:30
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2024
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch from f211942 to b7e2b7e Compare February 21, 2024 11:38
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96
Copy link
Contributor Author

@tobiasKaminsky Why I am getting this error in "ci/drone/pr" phase, have any idea?

"Failed to wait for server"

@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch 4 times, most recently from 9263bd8 to 4468344 Compare March 15, 2024 08:20
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/Check-Nullability-OCSRemoteOperation branch from 4468344 to 4f7b6d9 Compare March 18, 2024 08:17
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger AndyScherzinger merged commit 34aa8e8 into master Mar 18, 2024
19 of 20 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/Check-Nullability-OCSRemoteOperation branch March 18, 2024 16:11
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.19.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants