Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file version #1357

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Update file version #1357

merged 2 commits into from
Jan 8, 2025

Conversation

tobiasKaminsky
Copy link
Member

No description provided.

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Jan 3, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

github-actions bot commented Jan 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (3eb7173) to head (2a1e26d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...sources/files/ReadFileVersionsRemoteOperation.java 46.15% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1357      +/-   ##
============================================
+ Coverage     49.15%   49.27%   +0.11%     
- Complexity     1026     1035       +9     
============================================
  Files           215      215              
  Lines          8087     8088       +1     
  Branches       1038     1038              
============================================
+ Hits           3975     3985      +10     
+ Misses         3545     3534      -11     
- Partials        567      569       +2     
Files with missing lines Coverage Δ
...android/lib/resources/files/model/FileVersion.java 43.24% <100.00%> (+5.40%) ⬆️
...sources/files/ReadFileVersionsRemoteOperation.java 60.00% <46.15%> (+1.02%) ⬆️

... and 4 files with indirect coverage changes

@tobiasKaminsky tobiasKaminsky requested a review from ZetaTom January 7, 2025 12:10
@tobiasKaminsky tobiasKaminsky merged commit eeff723 into master Jan 8, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants