Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base url shall never be null #1485

Merged
merged 1 commit into from
Nov 20, 2024
Merged

base url shall never be null #1485

merged 1 commit into from
Nov 20, 2024

Conversation

tobiasKaminsky
Copy link
Member

No description provided.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (0c3c568) to head (76a860b).
Report is 235 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1485      +/-   ##
============================================
- Coverage     49.20%   49.16%   -0.04%     
+ Complexity     1001      998       -3     
============================================
  Files           208      208              
  Lines          7819     7815       -4     
  Branches       1017     1017              
============================================
- Hits           3847     3842       -5     
- Misses         3419     3420       +1     
  Partials        553      553              
Files with missing lines Coverage Δ
.../java/com/nextcloud/common/NextcloudUriDelegate.kt 87.50% <100.00%> (+4.16%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works after rebasing onto master.

@tobiasKaminsky tobiasKaminsky merged commit 0800cec into master Nov 20, 2024
20 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the nextcloudUri branch November 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants