Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Capabilities For Compatible File Names #1494

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

alperozturk96
Copy link
Contributor

No description provided.

@alperozturk96 alperozturk96 marked this pull request as draft July 3, 2024 08:36
Copy link
Contributor

github-actions bot commented Jul 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (e9316a5) to head (56fb2f1).
Report is 29 commits behind head on master.

Files Patch % Lines
...sources/status/GetCapabilitiesRemoteOperation.java 66.66% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1494      +/-   ##
============================================
+ Coverage     49.16%   49.24%   +0.07%     
- Complexity     1000     1005       +5     
============================================
  Files           208      208              
  Lines          7819     7835      +16     
  Branches       1017     1021       +4     
============================================
+ Hits           3844     3858      +14     
+ Misses         3421     3420       -1     
- Partials        554      557       +3     
Files Coverage Δ
...cloud/android/lib/resources/status/OCCapability.kt 94.20% <100.00%> (+0.35%) ⬆️
...sources/status/GetCapabilitiesRemoteOperation.java 51.03% <66.66%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jul 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Jul 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the feature/compatible-file-names branch from cd3ef73 to 3eb043f Compare July 8, 2024 14:58
Copy link
Contributor

github-actions bot commented Jul 8, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the feature/compatible-file-names branch 3 times, most recently from 6f03ff6 to afac23b Compare July 22, 2024 09:28
@alperozturk96 alperozturk96 marked this pull request as ready for review August 16, 2024 09:46
@nextcloud nextcloud deleted a comment from github-actions bot Aug 19, 2024
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky
Copy link
Member

I'd like to have a test for this.
But this would mean that we need to enable it via occ/config.php
I asked Ferdinand.

@alperozturk96 alperozturk96 merged commit 86b0279 into master Aug 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants