Apppassword onetime #1913
Apppassword onetime #1913
Conversation
tobiasKaminsky
force-pushed
the
apppassword-onetime
branch
from
d5cb052 to
203625d
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4823-IT-stable-09-43/debug/ |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4823-IT-master-09-43/debug/ |
ZetaTom
left a comment
ZetaTom
left a comment
There was a problem hiding this comment.
Works fine on my machine, except for the test case.
| @Test | ||
| fun generateAppPassword() { | ||
| // only on NC34+ | ||
| testOnlyOnServer(NextcloudVersion.nextcloud_34) |
There was a problem hiding this comment.
Comment in GenerateOneTimeAppPasswordRemoteOperation.kt says that this feature is available from Nextcloud 33.
There was a problem hiding this comment.
I'm not sure if this test case would work as expected.
As far as I understand, GenerateOneTimeAppPasswordRemoteOperation should only return an app password when authenticated using a one time password. However, nextcloudClient doesn't use a one time password, but a regular authenticated login instead. This means that any call to GenerateOneTimeAppPasswordRemoteOperation will fail and subsequently cause this test case to also fail.
On my machine the remote operation always returns a 403 Forbidden.
No description provided.