Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create share directly with note #772

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Create share directly with note #772

merged 3 commits into from
Apr 19, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 3, 2021 •
edited
Loading

  • make use of it in client

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 3, 2021
Open
AlvaroBrey
AlvaroBrey previously approved these changes Feb 17, 2022
View reviewed changes
@tobiasKaminsky tobiasKaminsky force-pushed the createShareWithNote branch 2 times, most recently from 15d0141 to 4d1f017 Compare May 5, 2022 13:35
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #772 (c899f2d) into master (1308887) will increase coverage by 0.10%.
The diff coverage is 70.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   51.02%   51.13%   +0.10%     
==========================================
  Files         180      180              
  Lines        6754     6761       +7     
  Branches      898      899       +1     
==========================================
+ Hits         3446     3457      +11     
+ Misses       2822     2817       -5     
- Partials      486      487       +1
Impacted Files Coverage Δ
...b/resources/shares/CreateShareRemoteOperation.java 80.00% <70.00%> (-1.25%) ⬇️

... and 3 files with indirect coverage changes

AlvaroBrey
AlvaroBrey previously approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@AlvaroBrey AlvaroBrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but please fix spotbugs or update the count

@tobiasKaminsky tobiasKaminsky requested a review from AlvaroBrey May 19, 2022 07:21
AlvaroBrey
AlvaroBrey previously approved these changes May 19, 2022
View reviewed changes
@AlvaroBrey
Copy link
Member

The CI errors seem unrelated to this PR, connected tests with master server are failing in master branch too.

tobiasKaminsky and others added 2 commits April 19, 2023 10:46
@tobiasKaminsky
Create share directly with note (NC24+)
7763aa8 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot @tobiasKaminsky
Analysis: update Spotbugs results to reflect reduced error/warning count
ef1bdfb 
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@tobiasKaminsky
another constructor
c899f2d 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@tobiasKaminsky tobiasKaminsky disabled auto-merge April 19, 2023 09:33
@tobiasKaminsky tobiasKaminsky merged commit f2a324d into master Apr 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the createShareWithNote branch April 19, 2023 09:33
@surinder-tsys surinder-tsys mentioned this pull request Apr 26, 2023
Merged
1 task
@tobiasKaminsky tobiasKaminsky mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey left review comments

Assignees
No one assigned
Labels
3. to review client change required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AlvaroBrey @nextcloud-android-bot