Support for checking if old login is used

[tobiasKaminsky]

Ref: nextcloud/android#1560

[AndyScherzinger]

I thought INVALID_SESSION_TOKEN is the indicator for using and old login, is it not?

[mario]

It indeed is.

…

On Wed, Sep 20, 2017 at 11:37 AM, Andy Scherzinger ***@***.*** > wrote: I thought INVALID_SESSION_TOKEN is the indicator for using and old login, is it not? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsgXoaC24AxRYKc5jWqbubhkkLgEMks5skNz1gaJpZM4PdmGo> .

[AndyScherzinger]

Then imho this needs to be the other way round:

if (isInvalidSessionToken(response)) {
    result = new RemoteOperationResult(false, status, post.getResponseHeaders());
} else {
     result = new
RemoteOperationResult(RemoteOperationResult.ResultCode.ACCOUNT_USES_OLD_LOGIN);
}

[mario]

You misunderstood :) Will clarify on IRC...

…

On Wed, Sep 20, 2017 at 11:53 AM, Tobias Kaminsky ***@***.***> wrote: Is it, but for storing it in arbitrary data provider (and for possible later usage) I think ACCOUNT_USES_OLD_LOGIN is a better/more descriptive name. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsm0rYsFTWcgFVTjhhPcHWN9SfzsDks5skOB-gaJpZM4PdmGo> .

[mario]

@tobiasKaminsky it is, but the issue is not in the name but where it should go. Also this will NOT trigger if you use old-login with app password. So maybe: ACCOUNT_USES_STANDARD_PASSWORD instead?

[tobiasKaminsky]

Thanks @AndyScherzinger, I fixed it.

[mario]

@AndyScherzinger @tobiasKaminsky thoughts on replacing the name to better signify what the actual problem is?

[tobiasKaminsky]

Also this will NOT trigger if you use old-login with app password.

I tried this, I logged into NC12 server with old login method (wait 60s on login and choose fallback). And then this was triggered.
Do I miss something?

[mario]

Well what I'm saying is ... if you login with an old login method to NC12 with the app password you generated yourself, Push should work and you should not get this error AFAIK.

[tobiasKaminsky]

Now I got it :-)
I will change the name to ACCOUNT_USES_STANDARD_PASSWORD

[AndyScherzinger]

👍 all comments implemented afaik + needs rebase now :)

[AndyScherzinger]

let's get this merged 🚀 @mario 😃

[mario]

👍

[AndyScherzinger]

👍