Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OkHttpMethodBase: prevent NPE when logging exception #983

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

AlvaroBrey
Copy link
Member

Seen in Play Console crash reports

ex.message may be null

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey
Copy link
Member Author

/backport to stable-2.12

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #983 (a33586c) into master (f5d3dc3) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         178      178           
  Lines        6678     6678           
  Branches      884      884           
=======================================
  Hits         3270     3270           
  Misses       2939     2939           
  Partials      469      469           
Impacted Files Coverage Δ
...main/java/com/nextcloud/common/OkHttpMethodBase.kt 69.09% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants