Skip to content

Commit

Permalink
Merge pull request #7030 from nextcloud/preventFirebaseCrashes
Browse files Browse the repository at this point in the history
Prevent firebase crashes
  • Loading branch information
AndyScherzinger authored Oct 2, 2020
2 parents b83bf82 + b66adb9 commit 501eb7d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
3 changes: 0 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ configurations {
ktlint

all {
exclude group: 'com.google.firebase', module: 'firebase-core'
exclude group: 'com.google.firebase', module: 'firebase-analytics'
exclude group: 'com.google.firebase', module: 'firebase-measurement-connector'
exclude group: 'org.jetbrains', module: 'annotations-java5' // via prism4j, already using annotations explicitly

// check for updates every build
Expand Down
2 changes: 1 addition & 1 deletion gplay.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependencies {
implementation "com.google.firebase:firebase-messaging:20.1.3"
implementation "com.google.firebase:firebase-messaging:20.2.4"
}
1 change: 1 addition & 0 deletions lint.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@
<ignore path="**/jetified-butterknife-runtime-10.**/**/lint.jar" />
<ignore path="**/jetified-dagger-lint-aar-2.29.**/**/lint.jar" />
<ignore path="**/jetified-annotation-experimental-1.**/**/lint.jar" />
<ignore path="**/jetified-firebase-installations**/**/lint.jar" />
</issue>
</lint>
7 changes: 5 additions & 2 deletions src/gplay/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,13 @@

<meta-data
android:name="firebase_analytics_collection_deactivated"
android:value="true"/>
android:value="true" />
<meta-data
android:name="google_analytics_adid_collection_enabled"
android:value="false"/>
android:value="false" />
<meta-data
android:name="google_analytics_ssaid_collection_enabled"
android:value="false" />

<activity
android:name=".authentication.ModifiedAuthenticatorActivity"
Expand Down

0 comments on commit 501eb7d

Please sign in to comment.