Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Upload only when connected to "x" network #2099

Closed
ghost opened this issue Feb 4, 2018 · 15 comments
Closed

Idea: Upload only when connected to "x" network #2099

ghost opened this issue Feb 4, 2018 · 15 comments
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.

Comments

@ghost
Copy link

ghost commented Feb 4, 2018

I'm really dying for the ability to allow automatic uploading only when connected to a specific network.

Currently I'm using Tasker to basically start the Nextcloud app only when I am connected to my home network. When on the local network where my Nextcloud server is running it allows uploading of images 100x faster. The problem is the mess of having to set this up and kill the app on a device reboot (so it won't upload on the wrong network).

Could we please get a simple feature to specific the SSID of networks we allow auto upload jobs to run when connected to?

Thanks.

@stratege1401
Copy link

the only wifi is not enough ???

@tobiasKaminsky
Copy link
Member

I think this overcomplicate things and we want to avoid too many manual config options.
We introduced "walled garden" check, so we already check if wifi is working.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky totally agree, while I get the motivation behind it which we may or may not consider an edge case. User sets up Nc in a LAN so the only time it makes sense to try to upload would be when connected to that LAN and there are others who argue that this is a security issue (which I disagree) since you might be using a open wifi hot spot "by accident".

For the later part I say disable auto connect open wifis, use ssl, use e2e.

Does "walled garden" detect general connectivity to the Nc instance? (Which some also consider a security issue since the rogue hacker wifi would get to know the server address...)

@tobiasKaminsky
Copy link
Member

Does "walled garden" detect general connectivity to the Nc instance?

Yes, as otherwise we would have to use some other url which then can track all the user.
"Revealing" the nextcloud server address is no security issue in my opinion as every single call to our app reveals the address.

In general, this request is similar to #436, and in my opinion out of scope of the app.

@AndyScherzinger
Copy link
Member

I'll agree with you with you on this issue, yes.

@OlivierBondu
Copy link

User sets up Nc in a LAN so the only time it makes sense to try to upload would be when connected to that LAN

This is exactly my use-case, my ISP doesn't allow for remote access of my private network, but in practice I don't care much. However I do care, for my battery life, that the app tries to connect whenever I am plugging my phone and there is a wifi network somewhere... I do not happen to only plug my phone at home.

I think this overcomplicate things and we want to avoid too many manual config options.

I do disagree this overcomplicates things, but in any case it could be part of the 'expert' options

I'm happy to help, but I don't know java 😄

@bene64
Copy link

bene64 commented Sep 11, 2018

I also have the usecase of a local NC instance without access to the internet (blame my ISP).

Is this still an issue (when it's in expert settings) which could be considered to be merged into the official app if there is somebody working on it?

@AndyScherzinger
Copy link
Member

@bene64 that is hard to tell since we never asked the designer's feedback. That said... @nextcloud/designers and @nextcloud/android any opinion on this? Asking for feedback

@AndyScherzinger AndyScherzinger added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Sep 11, 2018
@strugee
Copy link
Member

strugee commented Sep 11, 2018

So, it's not my decision to make since I'm not involved in the day to day of the Nextcloud Android app, but I do want to provide some context for those asking for this feature and note that UI complexity is only one of several costs new options bring. http://neugierig.org/software/blog/2018/07/options.html is a good explanation of the factors that go into a decision to add or not add a new option :)

@AndyScherzinger
Copy link
Member

Thanks for the input @strugee :)

This rquest has even more implication than the obvious one mentioned in the issue's description because this is basically a request for a wifi filter because one could argue that the same applies for manual uploads and that they need to be queued until the allowed wifi connection is available, same goes for showing that the client is not connected to this wifi since 3.3 will introduce "no internet" and "no server connection" messages for the users.

Furthermore to make it just a bit more complicated is that one might say "just for a list of SSIDs" or "not for a list of certain SSIDs".

What I am trying to say is that this is a quite complex matter and we also have to take into account that if we decide to implement such a mechanism that we need to come up with a good solution UI wise which is a tricky as to decide if and how to technically implement such a feature.

Personally I still think it is rather an edge case looking at the whole user base while I am aware that this doesn't make it any better for the people who might benefit from such an implementation :/

@bene64
Copy link

bene64 commented Sep 11, 2018

Depending on the „no server connection“ message in 3.3 my specific usecase could be resolved.
If an automatic upload doesn‘t fail because it simply isn‘t triggered because it can‘t connect to my local server, then I probably can life with it.

@AndyScherzinger
Copy link
Member

The message is just shown while browsing,the uploads would still fail at that moment. @tobiasKaminsky correct me if I'm wrong but the client should just restart the uploads when connected to the wifi thus it'll upload later when possible,right?

@tobiasKaminsky
Copy link
Member

This is the expected behaviour, yes

@AndyScherzinger
Copy link
Member

This is the expected behaviour, yes

@bene64 than you should be fine

@jancborchardt
Copy link
Member

Closing this hence. We simply can not add settings for every little thing as we need to test all settings and make sure everything works. Testing all these different settings would take a lot of resources from our already limited pool.

@strugee good read! :) I can recommend Choosing our preferences, which is a bit older and always holds up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.
Projects
None yet
Development

No branches or pull requests

7 participants