Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on file delete #2574

Closed
kollix opened this issue May 12, 2018 · 5 comments
Closed

crash on file delete #2574

kollix opened this issue May 12, 2018 · 5 comments

Comments

@kollix
Copy link

kollix commented May 12, 2018

nc-crash.txt

Actual behaviour

  • I rebooted the device and start Nextcloud client
  • I select one image via longtap
  • I select "Delete" from the menu to delete this image file
  • Nextcloud crashes

Expected behaviour

  • no crash, file deleted

Steps to reproduce

see above

Environment data

Android version:4.4.2

Device model: Samsung Galaxy Note II (GT-N7100)

Stock or customized system: stock

Nextcloud app version: 3.1.0 (from F-Droid)

Nextcloud server version: owncloud-8.2.11

Logs

attached

@ardevd
Copy link
Collaborator

ardevd commented May 14, 2018

@kollix Is the file actually deleted?

The stack trace you posted indicates a OutOfMemoryError exception which is odd.

@kollix
Copy link
Author

kollix commented May 14, 2018 via email

@tobiasKaminsky
Copy link
Member

still: why does it
com.owncloud.android.datamodel.ThumbnailsCacheManager.addThumbnailToCache(ThumbnailsCacheManager.java:174)
when I DELETE the file ???

For non-downloaded images we show a resized preview, which will be fetched from server.
However if you already have an image downloaded, delete it and immediately afterwards want to see the resized image, the device would have to download it.
That is the reason why we create the resized image on deletion.

After all this should not crash and should just create a resized image.

@kollix how big is the image in question?

@kollix
Copy link
Author

kollix commented May 16, 2018 via email

@stale
Copy link

stale bot commented May 10, 2019

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@stale stale bot added the stale label May 10, 2019
@stale stale bot closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants