Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Loss: Remotely deleting a Folder silently deletes unsynced local files #3288

Closed
gohrner opened this issue Nov 24, 2018 · 5 comments
Closed
Labels
bug needs info Waiting for info from user(s). Issues with this label will auto-stale. stale

Comments

@gohrner
Copy link

gohrner commented Nov 24, 2018

  1. On the Android phone, I added a new subfolder in the NextCloud folder
  2. I copied images there which were synced
  3. Later, I added some additional images, which, for reasons unknown to me, were not synced. :-/ (The phone was connected to WiFi all the time and it only was a handful of pictures.)
  4. Even later, on my Desktop computer which uses the NextCloud Linux Client, I moved the folder with the images somewhere else, out of NextCloud's reach.

Unfortunately, only then I noticed that after moving the folder, it did not contain the images I added in step 3.

As soon as I tried to open the folder on my Android device, it disappeared, and with it apparently the unsynced local images. Ouch!

Curiously, Google Fotos (which I only use because it came preinstalled as the only Gallery app, but I do not use its sync/online features) still shows the missing files, but in "information" it shows the now non-existent Nextcloud folder as the file location, and I cannot copy or share them in any way any more in the Fotos app. Apparently, Google Fotos uses a local cache which still contains the image file... Does anyone know any way to get them out there quickly before the are really deleted?

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #2281 ([Deleted]), #2382 (Delete multiple files), #181 (Empty local folder), #2574 (crash on file delete), and #627 (Delete ALL relevant local files once account is removed).

@tobiasKaminsky tobiasKaminsky added bug needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Jan 18, 2019
@tobiasKaminsky
Copy link
Member

Hm, if you upload files and the upload did not worked, they are still in the original folder, e.g. your DCIM…
Removing a remote folder only removes downloaded files within the NC app folder.

Can you explain the problem with a demo file, e.g.

  • take picture A
  • picture A is in /sdcard/DCIM/A.jpg
  • try to upload picture to folder /F while offline -> thus failing
  • remove folder /F

This is what I understand, but then in folder /F the picture A is not yet there, but still remains in /sdcard/DCIM/A.jpg, so removing /F should be no problem

@gohrner
Copy link
Author

gohrner commented Jan 18, 2019

Hm, if you upload files and the upload did not worked, they are still in the original folder, e.g. your DCIM…

I'm always using the "Move to Nextcloud folder" option as I do not want to have duplicate files on my phone.

This lead to the images which were not synced at the time I moved the folder away to be lost / deleted.

So the steps you describe are correct but the exception that the image is not in the DCIM folder any more.

@tobiasKaminsky
Copy link
Member

So the steps you describe are correct but the exception that the image is not in the DCIM folder any more.

This is really strange as the original file will only moved once the upload succeeded:

  • manually upload a file with "move to Nextcloud folder"
  • during upload cancel upload
  • file is still in original folder

@stale
Copy link

stale bot commented May 9, 2019

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@stale stale bot added the stale label May 9, 2019
@stale stale bot closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs info Waiting for info from user(s). Issues with this label will auto-stale. stale
Projects
None yet
Development

No branches or pull requests

3 participants