Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File detail: show exact modification timestamp #3389

Closed
memen45 opened this issue Dec 18, 2018 · 16 comments
Closed

File detail: show exact modification timestamp #3389

memen45 opened this issue Dec 18, 2018 · 16 comments

Comments

@memen45
Copy link

memen45 commented Dec 18, 2018

In the tab 'All Files' the full time stamps (of the form hh:mm(:ss) dd-mm-yyyy) are shortened to 'x days ago' or the date 'Nov 18' for example. This is all fine and makes the overview much more readable, however, this same shortened version is also shown in the file details activity. That makes it impossible to check the full date and time of a file or folder, which is very inconvenient.
screenshot_20181218-133132__01

@nextcloud-android-bot

This comment has been minimized.

@AndyScherzinger
Copy link
Member

pinging @nextcloud/designers @jancborchardt @tobiasKaminsky for input on this

@AndyScherzinger AndyScherzinger added enhancement design needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Dec 18, 2018
@AndyScherzinger
Copy link
Member

@jancborchardt @nextcloud/designers the webUI has a hover pop-over which shows the exact timestamp (Nc15 at least does so) while this is a concept we don't have on mobile. So we could either make it clickable to toggle between relative and absolute date of show the date on click via a pop-up or whatever even better idea you folks might come up :)

@tobiasKaminsky
Copy link
Member

Short click with a little pop up? But I am unsure which android component we can use.
Toggle on click would be the easiest way, I guess, but do we have enough space (in every language / date combination?)

@jancborchardt
Copy link
Member

Long-press could show a toast with the full time? This seems like a sort-of Android standard, which is also used to show the tooltips of icons in the top bar.

@tobiasKaminsky
Copy link
Member

which is also used to show the tooltips of icons in the top bar.

This is a built-in feature, but this is not available for TextViews as far as I found.
So we can show a toast on long click, but this then would be on standard position (bottom centered)…

@AndyScherzinger
Copy link
Member

So we can show a toast on long click, but this then would be on standard position (bottom centered)…

would be fine with me

@tobiasKaminsky
Copy link
Member

Like this…? I am unsure if

  • people will ever click on the date
  • people will recognize the toast down there

2018-12-20-105944

@AndyScherzinger
Copy link
Member

That would match the proposal of @jancborchardt
Like I meantioned somewhere before we could also just toggle the date on click while that would be hard to discover from a user perspective too...

@jancborchardt
Copy link
Member

Yeah, the toast is indeed very strange … the long-press is difficult to discover, and then it’s shown somewhere completely different.

The proposal with toggling the date display on tap seems much better! Sounds much more discoverable, and we could save the state globally (not per file :D), so that people who prefer the absolute dates are covered. But the default should stay relative date.

@AndyScherzinger
Copy link
Member

Sounds much more discoverable, and we could save the state globally (not per file :D)

Sounds good to me 👍 So globally also means for the file listings, not just the detail views, right?

@tobiasKaminsky
Copy link
Member

The proposal with toggling the date display on tap seems much better! Sounds much more discoverable,

How is this more discoverable?
I also think it is better, but still no user will know that clicking on the date is changing anything…

@jancborchardt
Copy link
Member

jancborchardt commented Dec 21, 2018

So globally also means for the file listings, not just the detail views, right?

No, only for the detail view. Only the place which changes it.

How is this more discoverable?
I also think it is better, but still no user will know that clicking on the date is changing anything…

Yes, it is more discoverable than long-press. Sure it’s still not obvious when compared to everything else, but for the few people who require this, either they might try tapping or word will eventually get out. It’s not a crucial feature that needs to be discovered by everyone.

@memen45
Copy link
Author

memen45 commented Dec 23, 2018

Tapping would indeed be a workable solution. Some other suggestions:

  1. Would it be possible to show both at the same time? Example:
    3 days ago, Thursday 20 December 2018, 17:32:23
  2. Would it be possible to show information more detailed? Example:
    File size: 168 KB
    Last Modified: Day dd Month yyyy, hh:mm:ss
    There should be more than enough space for this, as the rest of the activity is filled with the 'File Activities' tab.

Maybe the last suggestion addresses the File Detail view as a whole, not specifically the last modified date. In the 'All Files' tab, every item in the list already shows the size in short (e.g. 2.1 GB) and the date in short (e.g. 3 days ago or Nov 18):

aantekening 2018-12-23 183957

The File Detail view shows exactly this same short information, while I expect it to show more information than I already knew, e.g. 2.05 GB (2.210.334.237 bytes) and long date/time:

aantekening 2018-12-23 184202

Maybe this should be in a new issue though?

@jancborchardt
Copy link
Member

There should be more than enough space for this, as the rest of the activity is filled with the 'File Activities' tab.

It’s not about how many space there is, but how much information density we want. As this detail screen is something that is often accessed for sharing and activities, we shouldn’t put too much in there.

Let’s go with tapping as a first simple way.

AndyScherzinger pushed a commit that referenced this issue Jan 12, 2019
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger added a commit that referenced this issue Jan 12, 2019
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger removed the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Jan 12, 2019
@AndyScherzinger
Copy link
Member

#3399 resolves the date issue as discribed by @jancborchardt

@AndyScherzinger AndyScherzinger changed the title File detail exact time edited File detail: show exact modification timestamp Jan 12, 2019
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.5.0 milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants