-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photos missing caching feature #4235
Comments
There is now a PR ready to test: |
@tobiasKaminsky
|
Thank you very much for testing!
This sounds a bit too slow. It should only load 60 items.
This is known and an overall problem… :/
Hm. I did not changed anything in regard of creating thumbnails.
Do you know when this happens? e.g. all files -> photos -> all files?
Logs would be indeed here very helpful. Thanks again for your valuable feedback! |
It takes the same time regardless if I let it sit to do the caching. About 6-9 seconds on average with the new version and 18-20 with the old one for me.
Select photos from the drawer, then open the drawer and go back to "All Files". The "Photos" section will stay selected even if its no longer active. The app will crash if you select "Photos" from the drawer again. (All files>photos>all files>photos[crash])
I found out they will eventually load one by one very slowly. Yes, thumbnails are generated faster from the "files" section than from the gallery (also the non-QA version is faster at loading the thumbs in the gallery, as mentioned earlier). Another important issue I discovered was that some photos will refuse to fully load and instead are displayed by its thumbnail resolution, see below: Another highly important issue is that the folders will display images that are in fact not in those folders (talking about Files section now, not Photos). Go to one of the folders where the pictures are and let it load. Then, manually update that file by swiping your finger down. The "No files bug" will emerge for a second and then random pictures that do not belong in the folder will appear in that folder. (This problem is not present in the non-QA version of the app). |
You start measuring when clicking "photos" in drawer, but what is the end? Having a list of images/thumbnails/placeholder? |
No crash for me, but indeed drawer menu is highlighted wrong. |
The end of the measure is when photos are loaded: In the public version that means all photos are loaded, in QA it means only the top few are loaded (I wasn't trying to scroll down to load more as part of the measure). This means that the current (public) version loads the photos at faster rate -> It does take longer time but all photos are loaded (and with thumbnails, as opposed to QA ver.) Therefore I assume there may be something wrong with the way QA loads the photos.
It also stopped crashing for me, I don't know what was the culprit. I'll update if it starts crashing again. |
Can you give this a new try? I'll close this now, to have all reports in one. |
Actual behaviour
Expected behaviour
Steps to reproduce
Environment data
Android version: 9
Nextcloud app version: 3.7.0
Nextcloud server version: 15 snap
The text was updated successfully, but these errors were encountered: