Use reloading on photo view #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
replaceListWithRecyclerView
branch
from
c9f6c5c to
d4bed02
Compare
|
This will be a NC14+ feature as it depends on changes on webdav search. |
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
from
89b8829 to
fc0e389
Compare
2 tasks
tobiasKaminsky
force-pushed
the
replaceListWithRecyclerView
branch
5 times, most recently
from
9c9b1a4 to
32e5835
Compare
AndyScherzinger
changed the base branch from
replaceListWithRecyclerView
to
master
|
@tobiasKaminsky is this PR revive-able? Just asking because RecyclerView has already been merged and this PR has a lot of conflicts with master :/ |
|
I will try, once I have a bit space left. |
|
recyclerview PR has already been merged, so maybe a rebase on master will solve most of the issues automatically? |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10407.apk |
Codacy276Lint
SpotBugs (new)
SpotBugs (master)
|
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10407 |
|
@ezaquarii @AndyScherzinger I would like to get this into 3.8.0 RC1, which is scheduled for next Monday. |
|
IT test failure are unrelated. |
|
Fine with me : |
AndyScherzinger
approved these changes
Aug 16, 2019
|
Awaiting feedback from @ezaquarii :) |
|
I just tried the latest 10407.apk and it works way better than the previous 10374.apk (and that the current stable release): pictures are loading (relatively...) fast the first time the pictures section is clicked and when coming back, it's much (relatively...) faster since it seems it doesn't try to reload completely the pictures but instead relie on cache data. Also, pictures are displayed in some logical order, i.e. pictures last taken (or modified/loaded I guess) are displayed first. I would say that, at last, with these fixes, the pictures section of the ND app. would be usable. Thanks! |
ezaquarii
approved these changes
Aug 17, 2019
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10424.apk |
|
Oops.. I did some other tests (with 10407.apk) that were not so conclusive: upon exiting and coming back to the ND app, only grey icons were displayed in the pictures section and eventually, the app. crashed repetitively... Once I could get the pictures showing up again, it seemed that after it managed to display 95 images, it started to endlessly try to load the next ones, without any result... |
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10424 |
Codacy276Lint
SpotBugs (new)
SpotBugs (master)
|
|
@mlaverdiere do you have the crash stacktrace? |
|
Sorry, but how could I get the stacktrace? (just a regular user here, so I need some guidance...) 10424.apk loads pictures very fast, without any crash (so far), but again, stops after the first 95 images (endless spinning wheel) |
|
@mlaverdiere I'd expect you get a stacktrace displayed in a popup upon crash. It looks like this PR is behind master. I created another test build for you. This one should display the stack trace popup on crash: #4339 |
|
OK, i just tested the 10427 build: no crash to report yet, but still stops after 95 pictures... |
tobiasKaminsky
added a commit
that referenced
this pull request
Aug 21, 2019
b36067d Merge pull request #4294 from AlexNi245/#2216-activity-data-divers-design 9624019 activity header has now the same font size as a activity element fa11565 fixed issue Avoid reassigning parameters such as 'itemPosition' 5a3db5e replace do while loop in getHeaderPositionForItem with while loop 1dd2a5a change naming of Canvas c to Canvas canvas f4e964e change class name of ActivityListItemDecoration to StickyHeaderItemDecoration, which is more generic 52a7ffe add license text 6ffa9d0 remove duplicate entry of setContentView cdd5d38 add getHeaderPositionForItem unit test 0ac5a8b add static import for com.owncloud.android.lib.resources.activities.model.Activity; 4ea9667 unit test for isHeader(int pos) b61f9e0 format ActivityListAdapter 9012f43 set visibility from ActivityViewHeaderHolder back to protected 7a30070 remove unnecessary TAG field and replace nested if statement with && to fix codeacy-bot issues a26a895 apply changes to java doc c41dd38 optimize imports b4764f7 remove unnecessary files 792a6b9 finish implementation of sticky header implementation. This feature was created according to the this implementation : https://stackoverflow.com/questions/32949971/how-can-i-make-sticky-headers-in-recyclerview-without-external-lib 13e7aff increase height of header element and set backgroundcolor to white a184345 first implementation of sticky header logic. cd3d8dc start to implement sticky header behavior 259e106 Merge pull request #4355 from nextcloud/drawer caf1842 drawer: show only server address cb7d4a3 revert to old image (#4356) 7e44fec revert to old image f7c4eec Merge pull request #4345 from nextcloud/push a3fda5a no need to use owncloudClient 9a023c6 Check if app is excluded from battery optimization (#3589) 527c5db Use conscrypt (#4314) 6014e90 use conscrypt 5373660 Provide a banal 'paste' postmessage implementation. (#4189) 68cebf8 revert DeviceModule back to Kotlin 969ce78 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] f26095f Merge pull request #4245 from fogninid/fixUploadListComparator e72a789 show on special vendors "disable power check" in auto upload menu - tint button - change logic when to show battery warning c8173c3 Use reloading on photo view (#2250) c38dcf3 Delete temp file on receive external files (#4349) c155edf Merge pull request #4347 from nextcloud/blacklistThumbnail a03ff84 daily dev 20190820
|
as #1682 and #6138 are closed and redirect here: Photos pane in android app isn't working; I switched from release to dev and tried with Nextcloud-android/20200707, it seems to time out and eventually (after 30-60 seconds or so) gives the No Photos/Upload some photos or activate auto upload. The Photos App on the server works as expected (and there are definitely photos). Model: SM-N950N |
|
Same here with NC 18.0.6 and a Pixel 3a with the current Nextcloud App 3.12.1. Usually it only took unjustifiable long before the pictures appears, now it always times out. It also seems to be not easy to debug the app for a user, such as logging its requests to the server or some debugging console as browsers have it for debugging websites. |
The dev and debug builds do ship such a log view (accessible via the settings screen within the app) while this a general logging view, not one just for network communication |
|
other than that this is a (merged) PR, so it would be best to create an issue since discussions in merged, old PRs are rather getting lost in the Github notification noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4235
Fix #1972
Fix #1682
Fix #1901
Once this is merged, revert: nextcloud/android-library#322
Stalled by:nextcloud/server#15029nextcloud/server#15048This first loads 3x display items and on each bottom reach loads the next bunch of images.
Due to limitation of webdav this is currently only working if search is sorted by date, so not working on file names (for (favorite) search).
BUGS:
TODOs
Signed-off-by: tobiasKaminsky tobias@kaminsky.me