Delete temp file on receive external files #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
approved these changes
Aug 19, 2019
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10471.apk |
Codacy277Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4349 +/- ##
============================================
+ Coverage 16.53% 16.82% +0.28%
Complexity 1 1
============================================
Files 354 354
Lines 31515 31515
Branches 4477 4477
============================================
+ Hits 5211 5302 +91
+ Misses 25450 25325 -125
- Partials 854 888 +34
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4349 +/- ##
============================================
+ Coverage 16.53% 16.82% +0.28%
Complexity 1 1
============================================
Files 354 354
Lines 31515 31515
Branches 4477 4477
============================================
+ Hits 5211 5302 +91
+ Misses 25450 25325 -125
- Partials 854 888 +34
|
Closed
tobiasKaminsky
added a commit
that referenced
this pull request
Aug 21, 2019
b36067d Merge pull request #4294 from AlexNi245/#2216-activity-data-divers-design 9624019 activity header has now the same font size as a activity element fa11565 fixed issue Avoid reassigning parameters such as 'itemPosition' 5a3db5e replace do while loop in getHeaderPositionForItem with while loop 1dd2a5a change naming of Canvas c to Canvas canvas f4e964e change class name of ActivityListItemDecoration to StickyHeaderItemDecoration, which is more generic 52a7ffe add license text 6ffa9d0 remove duplicate entry of setContentView cdd5d38 add getHeaderPositionForItem unit test 0ac5a8b add static import for com.owncloud.android.lib.resources.activities.model.Activity; 4ea9667 unit test for isHeader(int pos) b61f9e0 format ActivityListAdapter 9012f43 set visibility from ActivityViewHeaderHolder back to protected 7a30070 remove unnecessary TAG field and replace nested if statement with && to fix codeacy-bot issues a26a895 apply changes to java doc c41dd38 optimize imports b4764f7 remove unnecessary files 792a6b9 finish implementation of sticky header implementation. This feature was created according to the this implementation : https://stackoverflow.com/questions/32949971/how-can-i-make-sticky-headers-in-recyclerview-without-external-lib 13e7aff increase height of header element and set backgroundcolor to white a184345 first implementation of sticky header logic. cd3d8dc start to implement sticky header behavior 259e106 Merge pull request #4355 from nextcloud/drawer caf1842 drawer: show only server address cb7d4a3 revert to old image (#4356) 7e44fec revert to old image f7c4eec Merge pull request #4345 from nextcloud/push a3fda5a no need to use owncloudClient 9a023c6 Check if app is excluded from battery optimization (#3589) 527c5db Use conscrypt (#4314) 6014e90 use conscrypt 5373660 Provide a banal 'paste' postmessage implementation. (#4189) 68cebf8 revert DeviceModule back to Kotlin 969ce78 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] f26095f Merge pull request #4245 from fogninid/fixUploadListComparator e72a789 show on special vendors "disable power check" in auto upload menu - tint button - change logic when to show battery warning c8173c3 Use reloading on photo view (#2250) c38dcf3 Delete temp file on receive external files (#4349) c155edf Merge pull request #4347 from nextcloud/blacklistThumbnail a03ff84 daily dev 20190820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4341
This happens only when sharing a file to NC app:
I set it now to "delete", meaning that the temp file is deleted.
We would also use "copy" so that the temporal file is being copied to NC app folder.
As we cannot ask user, I decided to simply do an upload.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me