Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardcode ignore ".thumbnail" #4347

Merged
merged 1 commit into from
Aug 20, 2019
Merged

hardcode ignore ".thumbnail" #4347

merged 1 commit into from
Aug 20, 2019

Conversation

tobiasKaminsky
Copy link
Member

Fix #3177

This is as simple as possible.
If we need at any time later something smarter, we can still do it.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
hardcode ignore ".thumbnail"
f22fb58 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10447

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10454

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10468.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

276

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings111
Security Warnings46
Dodgy code Warnings135
Total410

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings111
Security Warnings46
Dodgy code Warnings135
Total410

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #4347 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #4347     +/-   ##
===========================================
- Coverage     16.82%   16.53%   -0.3%     
  Complexity        1        1             
===========================================
  Files           354      354             
  Lines         31510    31515      +5     
  Branches       4474     4477      +3     
===========================================
- Hits           5303     5211     -92     
- Misses        25319    25450    +131     
+ Partials        888      854     -34
Impacted Files Coverage Δ Complexity Δ
...loud/android/datamodel/FilesystemDataProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 31.25% <0%> (-4.97%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 25.84% <0%> (-4.84%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 80.4% <0%> (-3.18%) 0% <0%> (ø)
...java/com/owncloud/android/utils/FileSortOrder.java 65.62% <0%> (-3.13%) 0% <0%> (ø)
.../owncloud/android/ui/activity/ToolbarActivity.java 60.86% <0%> (-2.9%) 0% <0%> (ø)
...om/owncloud/android/utils/FileSortOrderByName.java 11.42% <0%> (-2.86%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 18.32% <0%> (-1.96%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
... and 3 more

1 similar comment
@codecov
Copy link

codecov bot commented Aug 19, 2019 •
edited
Loading

Codecov Report

Merging #4347 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #4347     +/-   ##
===========================================
- Coverage     16.82%   16.53%   -0.3%     
  Complexity        1        1             
===========================================
  Files           354      354             
  Lines         31510    31515      +5     
  Branches       4474     4477      +3     
===========================================
- Hits           5303     5211     -92     
- Misses        25319    25450    +131     
+ Partials        888      854     -34
Impacted Files Coverage Δ Complexity Δ
...loud/android/datamodel/FilesystemDataProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 31.25% <0%> (-4.97%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 25.84% <0%> (-4.84%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 80.4% <0%> (-3.18%) 0% <0%> (ø)
...java/com/owncloud/android/utils/FileSortOrder.java 65.62% <0%> (-3.13%) 0% <0%> (ø)
.../owncloud/android/ui/activity/ToolbarActivity.java 60.86% <0%> (-2.9%) 0% <0%> (ø)
...om/owncloud/android/utils/FileSortOrderByName.java 11.42% <0%> (-2.86%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 18.32% <0%> (-1.96%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
... and 3 more

@AndyScherzinger AndyScherzinger merged commit c155edf into master Aug 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the blacklistThumbnail branch August 20, 2019 04:47
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Aug 20, 2019
tobiasKaminsky added a commit that referenced this pull request Aug 21, 2019
@tobiasKaminsky
daily dev 20190821
9da4251 
b36067d Merge pull request #4294 from AlexNi245/#2216-activity-data-divers-design
9624019 activity header has now the same font size as a activity element
fa11565 fixed issue  Avoid reassigning parameters such as 'itemPosition'
5a3db5e replace do while loop in getHeaderPositionForItem with while loop
1dd2a5a change naming of Canvas c to Canvas canvas
f4e964e change class name of ActivityListItemDecoration to StickyHeaderItemDecoration, which is more generic
52a7ffe add license text
6ffa9d0 remove duplicate entry of setContentView
cdd5d38 add getHeaderPositionForItem unit test
0ac5a8b add static import for com.owncloud.android.lib.resources.activities.model.Activity;
4ea9667 unit test for isHeader(int pos)
b61f9e0 format ActivityListAdapter
9012f43 set visibility from ActivityViewHeaderHolder back to protected
7a30070 remove unnecessary TAG field and replace nested if statement with && to fix codeacy-bot issues
a26a895 apply changes to java doc
c41dd38 optimize imports
b4764f7 remove unnecessary files
792a6b9 finish implementation of sticky header implementation. This feature was created according to the this implementation : https://stackoverflow.com/questions/32949971/how-can-i-make-sticky-headers-in-recyclerview-without-external-lib
13e7aff increase height of header element and set backgroundcolor to white
a184345 first implementation of sticky header logic.
cd3d8dc start to implement sticky header behavior
259e106 Merge pull request #4355 from nextcloud/drawer
caf1842 drawer: show only server address
cb7d4a3 revert to old image (#4356)
7e44fec revert to old image
f7c4eec Merge pull request #4345 from nextcloud/push
a3fda5a no need to use owncloudClient
9a023c6 Check if app is excluded from battery optimization (#3589)
527c5db Use conscrypt (#4314)
6014e90 use conscrypt
5373660 Provide a banal 'paste' postmessage implementation. (#4189)
68cebf8 revert DeviceModule back to Kotlin
969ce78 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
f26095f Merge pull request #4245 from fogninid/fixUploadListComparator
e72a789 show on special vendors "disable power check" in auto upload menu - tint button - change logic when to show battery warning
c8173c3 Use reloading on photo view (#2250)
c38dcf3 Delete temp file on receive external files (#4349)
c155edf Merge pull request #4347 from nextcloud/blacklistThumbnail
a03ff84 daily dev 20190820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger left review comments

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.8.0
Development

Successfully merging this pull request may close these issues.

.thumbdata files uploaded
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger