-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude specific folders from auto-upload discovery #5982
Comments
Hi @vincentmathis, So can you elaborate on these folder, storage path is rather to specific but folder names and cover art names, number of further images in that folder, possible names so we could implement a "smart" check to auto-exclude such folders :) |
In my case they are all called A possible way might be to check if a folder contains bunch of audio files (mp3, wav etc.) and one image file. That would usually indicate an music album with cover image. I just don't know how one would deal with false positives. |
This would be very useful, I also have a bunch of them, because the player I use downloads them automatically. I would disable that, but it's nice to see the cover when the album/piece is playing. They are created and placed under |
@jancborchardt @tobiasKaminsky what do you think? With #7042 (shipping with the next release) we will ignore/exclude folder with a single image (no other images) that is named @netphantm do these folder contain just a single image or can there be all/some files based on your expression |
@vincentmathis see comment above,the upcoming release will ignore folders with a single image named cover|folder.jpg (if you put in any other image we will detect it again (!) |
I would prefer to ignore images in complete Music folder. |
the folder inside the artist/album/ is named |
right, also an alternative. |
Very nice. That makes the auto-upload usable for me. Thanks for implementing this. Just like netphantm said I think a white/blacklist for directories could be useful. My gallery app has this and I love it because I can hide entire Folders of images that I don't want to see or add Folders that didn't automatically show up. Extremely useful! Any reason for not adding this? Maybe confusing "non power users" with extra settings? Still, this is a major first step for people who have a lot of albums of music on their sdcard. |
Like you mentioned, the reason is not adding extra settings that might confuse most users but rather find a nice set of fixed rules to improve this automatically for everybody. And yes, reading through the newest comments here I think it be good to just ignore the music main folder completely. Folders not auto detected can be added manually by the way (see 3 dot main menu on the top right, called set up custom folder). |
There are other standard folders on Android phones that could have the same problem: Users put their mp3 collection into Music, their VHS video collection into Video and their favorite photos into Pictures. All of these is unlikely to be intended to be synced into a cloud (as it is copied manually onto the phone). |
Ignoring all 3 is highly unlikely at least in my opinion. Pictures is a Android standard folder for images in contrast to DCIM for camera apps. So apps like Twitter, Facebook, etc. put explicitly downloaded images into a subfolder of pictures thus most people would rather want this to be not ignored. You can always hide folders via the auto upload folder item on the screen. If you put a '. nomedia' in the respective folder, so Android won't index the files in there and we won't detect and thus ignore it. So that has always been solved via Android standard mechanism ;) |
won't this also ignore the mp3s when they should be scanned by music apps?
I have about 50 folders and subfolders of mp3s, which may contain covers, so it'll be a PITA to manually hide them all after being auto discovered in "Auto upload".. |
That's true, while the initial suggestion of just ignoring the music folder would still work and is something I'd vote to do. The thing where I disagree is to completely ignore the Pictures folder since it is used by non-camera apps for image storage. |
It will indeed, which is why I don't have a I'm not sure if it's actually set as a formal standard anywhere, but there's a defacto standard of supporting a similar Excluding certain directories (and thus their children) from the scan as a config in the app (as this issue originally suggested) would work just fine for me too, I've seen that in a few gallery-type apps I've used. |
Problem is the scan logic is part of Android as in operating system while, yes we could check the folders content for such a file which wouldn't be too hard with the latest change to ignore certain folders based on their content 👍 So support a |
I am copying my MP3 collection to my phone. Nextcloud has discovered all these folders that have a couple of images each. Also importing my rip of the DVD boxset if Scrubs. Each episode has a few pictures from the show. Each episode is a new folder for Nextcloud auto-upload. |
I believe that decision is short sighted in this case. Taking the onus on yourselves to make the heuristics for every use case would be a) unobtainable b) impossible to maintain. Example I find myself wanting to ignore sub folders in my camera apps folder. The structure is this PHOTOGRAPHY_PRO\Burst{abillionfolders}. My camera app creates a new folder for every burst set of photos. Over the course of a couple hours I generated 200 such folders and over 3000 files. The scanning from Nextcloud at a time of heavy i/o from the camera app (it is bursting 20-30 images per second) is causing performance issues with my phone and for next cloud to get into some weird loop and queue up 20,000 uploads. I do not want to upload every single one of these burst photos as the point is to go back and select the ones I do want to keep which then go to the main PHOTOGRAPHY_PRO folder. I simply want to ignore all sub folders of the PHOTOGRAPHY_PRO or Burst folder.
.nomedia is not a suitable solution as the folder in question I do want to be available to photo and other apps on the device. I simply do not want the performance issues and consumption of bandwidth/disk space by Nextcloud handling all these many 100s of folders being created daily. |
For inspiration, I host navidrome and the dev included the possibility to add a .ndignore file to folders to be excluded from the scan |
Similar: #3239 |
Is your feature request related to a problem? Please describe.
I want to use the auto-upload feature and sometimes configure some custom folders. The problem here is that user potentially have a large number of folders containing a single album cover. In my case this means that opening the auto-upload page in the app takes 10+ seconds and sometimes even crashing and then shows 3000+ folders with a single image. I can't find the folders i actually want to manage unless i scroll for minutes.
Describe the solution you'd like
It would be nice to have a setting to exclude a path from the auto-upload discovery where one could pick to exclude everything in internal/music from auto-upload.
Describe alternatives you've considered
I do not know a way how to hide these folders except manually select "hide folder" for thousands of folders.
The text was updated successfully, but these errors were encountered: