-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔑 Support for client certificates #603
Comments
Hello mlsxlist, if this is of any use to the case, there is an open issue about this over at the owncloud github site: Best wishes |
Okay thanks! In some way this also enhances security. ;) |
@tobiasKaminsky let me think about it, and I'll come back to you - we need to focus on fixing current issues first to make the app (more) usable than it is now - thought definitely this is something we want to do in the future. |
I would also very much like to see this, because it protects from potential issues with the login page as well as weak passwords and password guessing attacks. |
Any news on this ? This is a very important enhancement ! |
@mario let me know if you still need a test setup with client certificates enabled. In the meantime I will try to look into this (I haven't worked on android apps yet, but I can find my way around in php/java/python so I will give it a try) |
@AndreasMettlen yes I do. Send me the required cert + url, server and pass to mario@nextcloud.com :) |
@mario Did you have a chance yet to look into this ? |
@mario Did the second certificate and the talk app help you in making progress on this issue ? |
@AndreasMettlen I implemented the initial support for client cert in Talk app. Now I need to validate it works which is why I asked for the second one. I'll try to do that on Friday. If it works, I can see how easy/hard it is to put it into the Files (this) app. |
Hi, AuthenticatorActivity
Then it uses the cert to initialize the SslSocketFactory: NetworkUtils (nextcloud-android-library)
That's a big paste-up of various articles and posts that I've read to try to solve the problem... unfortunately I can't remember all of them: Hope it helps. |
@mbrescia feel free to start a patch, and I can help? In the mean time, maybe you can try Nextcloud Talk v1.2.0beta? Same for you @AndreasMettlen ^_^ |
Hello @mario I have android 8.1.0 |
@ClCfe can you file a bug here, preferably with stacktrace? |
@mbrescia |
@proton2b |
@mbrescia |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any news on the topic? Still not implemented but would be awesome to have! |
Done with Huge thanks to @Elv1zz who did 99,95% of the work 🎉 |
Any plan on adding it to release? |
It's planned to ship it with the next feature release 3.29 - scheduled for 24th April |
Maybe I'm just blind, but how can I specify a client certificate when signing in with the android app? Is this a hidden feature that is only enabled when a client certificate is required or how does it work? I'm using 3.30.0 and how I understand it the feature should be added with 3.29.0. When I add a new account, I only see two options to enter the url of the server, manually or scan the configuration with a qr code. After that a browser is opened to sign into nextcloud. |
I just imported the client certificate in the device store. Then, there is
prompt asking to choose a certificate. The client certificate in my case is
issued from the configured and enforced for clients in the nextcloud
publishing proxy.
…On Fri, Sep 27, 2024, 10:03 kaikli ***@***.***> wrote:
Maybe I'm just blind, but how can I specify a client certificate when
signing in with the android app? Is this a hidden feature that is only
enabled when a client certificate is required or how does it work?
I'm using 3.30.0 and when I add a new account, I only see two options to
enter the url of the server. Enter it manually or scan the configuration
with a qr code. After that a browser is opened to sign into nextcloud.
—
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHTE3MNG5G5AYUC6L6WHFTZYT7K7AVCNFSM6AAAAABO6QYIW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGU2DIOJZG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yes, exactly. There is no direct way to configure the nextcloud connection, so especially no explicit selection of the certificate before trying to establish the connection. The certificate selection dialog appears when the server asks for a certificate. That's the way nexctloud connections are configured (so far). I personally prefer an explicit configuration, like e.g. DAVx uses it. |
Actual behaviour
In order to secure Nextcloud on TLS level, it would be good if the app could support client certificates. If the client certificate is not sent on handshake, the server prevents access to Nextcloud logon page. This would provide a second line of defense.
Expected behaviour
Nextcloud app should support client certificates as other apps like caldav sync and carddav sync already do.
The text was updated successfully, but these errors were encountered: