Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetStatusDialogFragment: fix nullability of itemSelected parameter #10489

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

AlvaroBrey
Copy link
Member

Prevents crash when fragment is recreated (like when dark mode is switched)

Rel #10488

  • Tests written, or not not needed

Prevents crash when fragment is recreated (like when switching dark mode)

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10489.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2828
Correctness4646
Dodgy code356356
Experimental11
Internationalization99
Multithreaded correctness99
Performance6363
Security2828
Total540540

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky merged commit 4fc60c2 into master Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/crash-status-dialog-darkmode branch July 7, 2022 12:32
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.21.0 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants