-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete all local files on account removal #1109
Conversation
you can't I#d say, the user could also copy all the files manually and then delete the account. |
So you are fine with this? |
Well you could run the remove process in a job ... |
Sure, but I wanted to have this done on the moment the user clicks on it and not scheduled for sometimes later. |
Solution:
|
@tobiasKaminsky yes, that means I am fine with deleting all local files on account removal 👍 |
@tobiasKaminsky can you please do the things I've written here so we can merge this? |
Done 🎉 Tested with
|
@AndyScherzinger if you feel like this is ok, feel free to merge - I will not be able to review it in a while. Thanks. |
- switch to other acc if it exists, if not show login screen - run a job with all the delete magic - prevent adding the same account while there is pending delete for that account
5e4f458
to
87ae252
Compare
Ref: #627
To discuss: